Make a proper way to clean state cookie #139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In the #136 PR, we add a feature to protect CSRF attack by put the
state
parameter into cookie, and we remove thestate
cookie is after thehandle_callback!/1
function of the strategy in this changes, before this PR changes, in thehandle_callback!/1
function of the strategy we can do any proper process with Plug, but now we may see a similar "AlreadySentError" error if we make a redirection in thehandle_callback!/1
:In this PR, I change to put the
state
cookie clean before runhandle_callback!/1
, since the state parameter in cookie should be transparent for the strategy, and add a test case to catch this.Please review and advise, cc @yordis @doomspork .
Thanks.