Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: remove privateassets="all" from mauiembedding bits (backport #20797) #20800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agneszitte merged 1 commit into from
Jun 17, 2025
Merged

fix: remove privateassets="all" from mauiembedding bits (backport #20797) #20800

agneszitte merged 1 commit into from
Jun 17, 2025

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 16, 2025

This is an automatic backport of pull request #20797 done by [Mergify](https://mergify.com).

@mergify mergify bot mentioned this pull request Jun 16, 2025
Merged
@agneszitte agneszitte enabled auto-merge June 16, 2025 22:57
@unodevops
Copy link
Contributor

unodevops commented Jun 16, 2025

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-20800/docs/index.html

@unodevops
Copy link
Contributor

unodevops commented Jun 16, 2025

🤖 Your WebAssembly Native Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-20800/wasm-native-net9/index.html

@nventive-devops
Copy link
Contributor

nventive-devops commented Jun 17, 2025

The build 168600 found UI Test snapshots differences: android-28-net8: 20, android-28-net8-Snap: 58, ios: 5, ios-Snap: 42, skia-linux-screenshots: 77, skia-windows-screenshots: 375, wasm: 83, wasm-automated-net9.0-WinUI-Benchmarks-automated: 1, wasm-automated-net9.0-WinUI-Default-automated: 13, wasm-automated-net9.0-WinUI-RuntimeTests-0: 0, wasm-automated-net9.0-WinUI-RuntimeTests-1: 0, wasm-automated-net9.0-WinUI-RuntimeTests-2: 0

Details

  • android-28-net8: 20 changed over 824

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CheckBox_DoubleTapValidation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • WebView_NavigateToAnchor_Initial
    • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • When_BitmapIcon_Generic_Changed
    • When_BitmapIcon_Generic_Initial
    • When_BitmapIcon_Generic_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Generic
    • When_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • MinMaxTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • XBind_Validation_Uno_UI_Samples_Content_UITests_XBind_XBind_Simple

  • android-28-net8-Snap: 58 changed over 1068

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • Border_Border_Simple_No_Background_With_TextBox_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background_With_TextBox
    • Border_Border_Simple_with_non_Uniform_Thickness_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_non_Uniform_Thickness
    • CommandBar_Long_Title_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
    • CommandBar_Native_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Native
    • Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • Border_Border_Simple_No_Background_With_Content_Border_With_Background_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_No_Background_With_Content_Border_With_Background
    • Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
    • Scrolling_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage_MUXControlsTestApp_ScrollViewKeyboardAndGamepadNavigationPage
    • Border_ZeroThickness_Uno_UI_Samples_UITests_BorderTestsControl_ZeroThickness
    • CommandBar_Extensions_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Extensions
    • CommandBar_Flyouts_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_Flyout
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_Measure
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
    • Border_BorderCenteredwithmargins_Uno_UI_Samples_UITests_BorderTestsControl_BorderCenteredwithmargins
    • Border_ZeroThicknessWithRadius_Uno_UI_Samples_UITests_BorderTestsControl_ZeroThicknessWithRadius

  • ios: 5 changed over 255

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView_ObservableCollection_Creation_Count_Removed_above
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ListView_ObservableCollection_Creation_Count_Scrolled2
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ListView_ObservableCollection_Creation_Count_Added_above

  • ios-Snap: 42 changed over 985

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Focus_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusCycle_UITests_Windows_UI_Xaml_FocusTests_Focus_FocusCycle
    • TextBlock_TextBlockMultilineInStarStackPanel_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlockMultilineInStarStackPanel
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • Brushes_ImageBrushWithScaleTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithScaleTransform
    • MenuBar_SimpleMenuBar_UITests_Shared_Windows_UI_Xaml_Controls_MenuBarTests_SimpleMenuBar
    • NavigationView_MUXControlsTestApp_NavigationViewCompactPaneLengthTestPage_MUXControlsTestApp_NavigationViewCompactPaneLengthTestPage
    • Pickers_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • ContentPresenter_ContentPresenter_Background_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Background
    • TextBox_Input_InputScope_Number_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_InputScope_Number
    • ToggleSwitch_Native_ToggleSwitch_IsOn_SamplesApp_Windows_UI_Xaml_Controls_ToggleSwitchControl_Native_ToggleSwitch_IsOn
    • Windows_Phone_Devices_Notifications_VibrationDevice_UITests_Shared_Windows_Phone_Devices_Notifications_VibrationDevice
    • Brushes_EllipsemaskingEllipseGrid_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipsemaskingEllipseGrid
    • NavigationView_MUXControlsTestApp_NavigationViewMenuItemStretchPage_MUXControlsTestApp_NavigationViewMenuItemStretchPage
    • TextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
    • Brushes_PanelImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_PanelImageBrush
    • MUX_MUXControlsTestApp_RefreshContainerOnImagePage_MUXControlsTestApp_RefreshContainerOnImagePage
    • Scrolling_MUXControlsTestApp_ScrollViewDynamicPage_MUXControlsTestApp_ScrollViewDynamicPage
    • Brushes_ImageBrushWithRotateTransform_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushWithRotateTransform
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical

  • skia-linux-screenshots: 77 changed over 2250

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CalendarView_Theming.png-dark
    • CalendarView_Theming.png
    • ClipboardTests.png-dark
    • ClipboardTests.png
    • DropDownButtonPage.png-dark
    • DropDownButtonPage.png
    • Gamepad_CurrentReading.png-dark
    • Gamepad_CurrentReading.png
    • DisplayInformation.png-dark
    • DisplayInformation.png
    • Examples.png
    • ExpanderColorValidationPage.png-dark
    • ExpanderColorValidationPage.png
    • Gamepad_Enumeration.png-dark
    • Gamepad_Enumeration.png
    • Image_Stretch_None.png-dark
    • Image_Stretch_None.png
    • Buttons.png-dark
    • Buttons.png
    • ImageIconPage.png-dark

  • skia-windows-screenshots: 375 changed over 2250

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • AnimatedIconPage.png
    • ApplicationViewSizing.png-dark
    • AppWindowClosing.png-dark
    • AuthenticationBroker_Demo.png-dark
    • AuthenticationBroker_Demo.png
    • BasicEnability.png
    • AppWindowPositionAndSize.png
    • CameraCaptureUISample.png
    • BasicEnability.png-dark
    • ElevatedView_Tester.png-dark
    • ElevatedView_Tester.png
    • ComboBox_ItemDataContext.png-dark
    • CommandBar_Primary_And_Secondary.png-dark
    • CommandBar_Primary_And_Secondary.png
    • DropDownButtonPage.png-dark
    • DropDownButtonPage.png
    • Examples.png
    • AnimatedIconPage.png-dark
    • AppWindowPresenters.png-dark
    • AppWindowClosing.png

  • wasm: 83 changed over 1052

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.InfoBarPage
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_ItemContainerStyleSelector
    • UITests.Windows_UI_Xaml_Media.FontTests.DynamicFont
    • Uno.UI.Samples.Content.UITests.ButtonTestsControl.RadioButton_Multiple_Unnamed_Groups
    • Uno.UI.Samples.Content.UITests.ButtonTestsControl.RadioButton_With_GroupName
    • initial_state
    • SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_Static
    • SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_WithHeaders
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.UndefinedHeightListView
    • UITests.Microsoft_UI_Xaml_Controls.CommandBarTests.CommandBar_Primary_And_Secondary
    • UITests.Shared.Windows_UI_Xaml.WebView_Alert
    • UITests.Windows_UI_Xaml_Controls.ListView.ListViewItem_IsEnabled
    • UITests.Windows_UI_Xaml_Controls.ListView.ListView_DisplayMemberPath
    • SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_JavascriptInvoke
    • SamplesApp.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_ChromeClient
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Inside_ListView
    • UITests.Shared.Microsoft_UI_Xaml_Controls.WebView2Tests.WebView2_NavigateToString2
    • UITests.Shared.Windows_UI_Xaml.WebView2_Alert
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_SelectedIndex
    • UITests.Shared.Windows_UI_Xaml_Controls.CommandBar.CommandBar_Xaml_Automated

  • wasm-automated-net9.0-WinUI-Benchmarks-automated: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunBenchmarks_Benchmarks_Shared_Controls_BenchmarkDotNetTestsPage

  • wasm-automated-net9.0-WinUI-Default-automated: 13 changed over 876

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_StrokeThickness_MyPolygon
    • When_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Default_StrokeThickness_MyRect
    • Default_StrokeThickness_MyPolyline
    • Default_StrokeThickness_MyLine
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Default_StrokeThickness_MyPath
    • Default_StrokeThickness_MyEllipse
    • When_Theme_Changed_No_Crash_UITests_Windows_UI_Xaml_Controls_CalendarView_CalendarView_Theming
    • Late_With_UniformToFill_UITests_Windows_UI_Xaml_Controls_ImageTests_ImageWithLateSourceUniformToFill
    • ToggleCollapsedStateToVerifyClipping_UITests_Shared_Microsoft_UI_Xaml_Controls_ExpanderTests_ExpanderColorValidationPage
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features

  • wasm-automated-net9.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net9.0-WinUI-RuntimeTests-2: 0 changed over 1

@agneszitte agneszitte merged commit 4c6fc11 into release/stable/6.0 Jun 17, 2025
90 of 91 checks passed
@agneszitte agneszitte deleted the mergify/bp/release/stable/6.0/pr-20797 branch June 17, 2025 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazo0 kazo0 kazo0 approved these changes

@agneszitte agneszitte agneszitte approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@unodevops @nventive-devops @kazo0 @agneszitte