Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improves XAML code gen (Error reporting + HR) (backport #21867) #21900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
agneszitte merged 10 commits into from
Nov 19, 2025
Merged

Improves XAML code gen (Error reporting + HR) (backport #21867) #21900

agneszitte merged 10 commits into from
Nov 19, 2025

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2025

closes #21860
closes https://github.com/unoplatform/uno.hotdesign/issues/5418

✨ Feature / 🐞 Bugfix

✨ Add ability to pass over invalid binding syntax in code gen
🐞Fix possible ENC0004 with HR

What is the current behavior? 🤔

  • Fails when facing invalid syntax in bindings
  • With some specific changes we might get a ENC0004 error because fuzzy matching or method name confuse changes and think that a method modifier has been changed.

What is the new behavior? 🚀

  • Properly reports error and continue generation when an invalid syntax for binding is found
  • When HR is enabled, we don't generate static method.

PR Checklist ✅

Other information ℹ️

This PR is based on #21865 (and contains same changes)

This is an automatic backport of pull request #21867 done by Mergify.

dr1rrb added 10 commits November 19, 2025 20:58
@dr1rrb @mergify
feat: Enhance parser en code gen to pass over invalid syntax in Bindings
196a341 
(cherry picked from commit e4d7f8e)
@dr1rrb @mergify
test: Add second test case
ab3cddf 
(cherry picked from commit 425dd7a)
@dr1rrb @mergify
chore: IDE0051
94ea97c 
(cherry picked from commit 4457c68)
@dr1rrb @mergify
test: Add failing HR test
5ce8056 
(cherry picked from commit 22ccd4d)
@dr1rrb @mergify
chore: IDE0055
a7f112b 
(cherry picked from commit 91cb1f8)
@dr1rrb @mergify
fix: Fix possible ENC0004 with HR
b850a13 
(cherry picked from commit 86741af)
@dr1rrb @mergify
test: Add test for full XML binding
7bd28b2 
(cherry picked from commit 58ea499)
@dr1rrb @mergify
feat: Restore static method when hot reload disabled
38d52bf 
(cherry picked from commit 7fef569)
@dr1rrb @mergify
test: Add new failing IRL case
e2f6563 
(cherry picked from commit 26e6e32)
@dr1rrb @mergify
test: Adjust test results path gen to avoid conflicts between tests
b9b98e8 
(cherry picked from commit df7e72f)
@mergify mergify bot mentioned this pull request Nov 19, 2025
Merged
5 tasks
@github-actions github-actions bot added the area/code-generation Categorizes an issue or PR as relevant to code generation label Nov 19, 2025
@agneszitte agneszitte merged commit 3d9deeb into release/stable/6.4 Nov 19, 2025
11 of 27 checks passed
@agneszitte agneszitte deleted the mergify/bp/release/stable/6.4/pr-21867 branch November 19, 2025 21:11
@unodevops
Copy link
Contributor

unodevops commented Nov 19, 2025

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21900/docs/index.html

@unodevops
Copy link
Contributor

unodevops commented Nov 19, 2025

🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21900/wasm-skia-net9/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agneszitte agneszitte agneszitte approved these changes

Assignees

No one assigned

Labels

area/code-generation Categorizes an issue or PR as relevant to code generation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@unodevops @agneszitte @dr1rrb