Type inference #495

jonasstrehle · 2025-11-01T09:55:28Z

This PR updates the type formatter to use the new visitor trait of #461

Refactor DatexExpression and DatexTypeExpression to include the inferred type
Use the type inference trait to update a RichAst coming from the precompiler to include the type inference of metadata and expressions
Proper error handling for invalid assignments / bad operations / type mismatch
Move all tests from old type_inference module to new modules
Deprecate old type_inference.rs module and dependencies
Rename typedef to typealias
Fix structural vs nominal type reference replacement in declaration

See https://github.com/unyt-org/datex-core/tree/feat/type-inference/src/type_inference

Copilot

Pull Request Overview

This is a major refactoring pull request that restructures the codebase's module organization and introduces visitor patterns for AST traversal. The changes reorganize code from a monolithic precompiler.rs into separate, focused modules.

Key Changes:

Splits precompiler functionality into separate modules (precompiler/mod.rs, scope.rs, scope_stack.rs, precompiled_ast.rs)
Introduces visitor pattern for expressions and type expressions with new visitor module
Adds type inference system with detailed error handling
Introduces formatter module for code formatting with configurable options
Updates import paths throughout codebase to reflect new structure

Reviewed Changes

Copilot reviewed 70 out of 72 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`src/visitor/type_expression/visitable.rs`	Implements visitor pattern for type expressions with `walk_children` methods
`src/visitor/type_expression/mod.rs`	Defines `TypeExpressionVisitor` trait with visit methods for each type variant
`src/visitor/expression/visitable.rs`	Implements visitor pattern for expressions with `walk_children` methods
`src/visitor/expression/mod.rs`	Defines `ExpressionVisitor` trait extending `TypeExpressionVisitor`
`src/visitor/mod.rs`	Defines `VisitAction` enum and includes tests for visitor implementation
`src/type_inference/mod.rs`	Implements type inference using visitor pattern
`src/type_inference/error.rs`	Defines error types for type inference
`src/type_inference/options.rs`	Configuration options for type inference
`src/precompiler/mod.rs`	Main precompiler logic refactored from old `compiler/precompiler.rs`
`src/precompiler/precompiled_ast.rs`	AST metadata structures
`src/precompiler/scope_stack.rs`	Scope management during precompilation
`src/fmt/mod.rs`	Code formatter with pretty printing
`src/runtime/mod.rs`	Added debug print statement

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/runtime/mod.rs

github-actions · 2025-11-01T10:02:19Z

Test Results

572 tests +6 572 ✅ +6 1m 10s ⏱️ +2s
6 suites ±0 0 💤 ±0
1 files ±0 0 ❌ ±0

Results for commit bebe88b. ± Comparison against base commit 2312077.

♻️ This comment has been updated with latest results.

github-actions · 2025-11-01T11:02:56Z

Bencher Report

Branch	feat/type-inference
Testbed	ubuntu-latest

Click to view all benchmark results

Benchmark	Latency	Benchmark Result microseconds (µs) (Result Δ%)	Upper Boundary microseconds (µs) (Limit %)
dxb to json/test1.json	📈 view plot 🚷 view threshold	61.29 µs (-3.77%) Baseline: 63.69 µs	67.60 µs (90.66%)
dxb to json/test2.json	📈 view plot 🚷 view threshold	13,307.00 µs (+0.07%) Baseline: 13,297.86 µs	13,721.92 µs (96.98%)
dxb to json/test3.json	📈 view plot 🚷 view threshold	141,920.00 µs (-0.55%) Baseline: 142,700.00 µs	147,771.66 µs (96.04%)
dxb to runtime value/test1.json	📈 view plot 🚷 view threshold	54.60 µs (+37.59%) Baseline: 39.68 µs	59.00 µs (92.54%)
dxb to runtime value/test2.json	📈 view plot 🚷 view threshold	14,562.00 µs (+33.34%) Baseline: 10,920.86 µs	15,769.22 µs (92.34%)
dxb to runtime value/test3.json	📈 view plot 🚷 view threshold	159,880.00 µs (+65.70%) Baseline: 96,490.43 µs	177,986.36 µs (89.83%)
json to dxb/test1.json	📈 view plot 🚷 view threshold	8,285.50 µs (+378.00%) Baseline: 1,733.38 µs	10,139.86 µs (81.71%)
json to dxb/test2.json	📈 view plot 🚷 view threshold	8,699,000.00 µs (+519.44%) Baseline: 1,404,337.14 µs	10,763,317.27 µs (80.82%)
json to dxb/test3.json	📈 view plot 🚷 view threshold	49,843,000.00 µs (+468.88%) Baseline: 8,761,642.86 µs	61,468,591.49 µs (81.09%)
json to runtime value datex auto static detection/test1.json	📈 view plot 🚷 view threshold	8,232.60 µs (+374.93%) Baseline: 1,733.42 µs	10,071.82 µs (81.74%)
json to runtime value datex auto static detection/test2.json	📈 view plot 🚷 view threshold	8,757,000.00 µs (+517.69%) Baseline: 1,417,710.00 µs	10,833,948.07 µs (80.83%)
json to runtime value datex auto static detection/test3.json	📈 view plot 🚷 view threshold	50,055,000.00 µs (+465.32%) Baseline: 8,854,271.43 µs	61,714,396.64 µs (81.11%)
json to runtime value datex forced static/test1.json	📈 view plot 🚷 view threshold	8,005.90 µs (+372.33%) Baseline: 1,694.99 µs	9,791.83 µs (81.76%)
json to runtime value datex forced static/test2.json	📈 view plot 🚷 view threshold	8,556,100.00 µs (+517.31%) Baseline: 1,386,032.86 µs	10,585,159.52 µs (80.83%)
json to runtime value datex forced static/test3.json	📈 view plot 🚷 view threshold	48,987,000.00 µs (+465.74%) Baseline: 8,658,942.86 µs	60,399,424.40 µs (81.11%)
json to runtime value datex/test1.json	📈 view plot 🚷 view threshold	8,170.20 µs (+372.56%) Baseline: 1,728.92 µs	9,993.02 µs (81.76%)
json to runtime value datex/test2.json	📈 view plot 🚷 view threshold	8,720,800.00 µs (+516.00%) Baseline: 1,415,712.86 µs	10,788,070.76 µs (80.84%)
json to runtime value datex/test3.json	📈 view plot 🚷 view threshold	50,005,000.00 µs (+463.97%) Baseline: 8,866,542.86 µs	61,646,759.61 µs (81.12%)
json to runtime value json_syntax/test1.json	📈 view plot 🚷 view threshold	20.91 µs (+3.38%) Baseline: 20.23 µs	21.49 µs (97.29%)
json to runtime value json_syntax/test2.json	📈 view plot 🚷 view threshold	6,531.70 µs (-0.34%) Baseline: 6,553.79 µs	6,976.55 µs (93.62%)
json to runtime value json_syntax/test3.json	📈 view plot 🚷 view threshold	70,147.00 µs (-14.68%) Baseline: 82,216.43 µs	97,865.35 µs (71.68%)
json to runtime value serde_json/test1.json	📈 view plot 🚷 view threshold	6.19 µs (-1.49%) Baseline: 6.28 µs	6.54 µs (94.53%)
json to runtime value serde_json/test2.json	📈 view plot 🚷 view threshold	2,071.10 µs (-2.75%) Baseline: 2,129.59 µs	2,214.41 µs (93.53%)
json to runtime value serde_json/test3.json	📈 view plot 🚷 view threshold	14,630.00 µs (-9.68%) Baseline: 16,197.14 µs	18,744.71 µs (78.05%)
runtime init	📈 view plot 🚷 view threshold	32.14 µs (-76.78%) Baseline: 138.44 µs	1,198.66 µs (2.68%)
runtime value to dxb/test1.json	📈 view plot 🚷 view threshold	6.19 µs (+66.80%) Baseline: 3.71 µs	6.89 µs (89.81%)
runtime value to dxb/test2.json	📈 view plot 🚷 view threshold	1,669.10 µs (+70.40%) Baseline: 979.49 µs	1,864.33 µs (89.53%)
runtime value to dxb/test3.json	📈 view plot 🚷 view threshold	18,672.00 µs (+84.56%) Baseline: 10,116.79 µs	21,133.60 µs (88.35%)
runtime value to json datex/test1.json	📈 view plot 🚷 view threshold	67.22 µs (-1.35%) Baseline: 68.15 µs	71.30 µs (94.28%)
runtime value to json datex/test2.json	📈 view plot 🚷 view threshold	14,763.00 µs (+2.78%) Baseline: 14,364.14 µs	15,076.52 µs (97.92%)
runtime value to json datex/test3.json	📈 view plot 🚷 view threshold	159,750.00 µs (+3.25%) Baseline: 154,720.00 µs	163,035.16 µs (97.98%)
runtime value to json json_syntax/test1.json	📈 view plot 🚷 view threshold	10.42 µs (-2.58%) Baseline: 10.70 µs	11.16 µs (93.41%)
runtime value to json json_syntax/test2.json	📈 view plot 🚷 view threshold	4,362.50 µs (-3.66%) Baseline: 4,528.37 µs	4,788.16 µs (91.11%)
runtime value to json json_syntax/test3.json	📈 view plot 🚷 view threshold	58,463.00 µs (-7.20%) Baseline: 62,995.86 µs	71,745.59 µs (81.49%)
runtime value to json serde_json/test1.json	📈 view plot 🚷 view threshold	2.85 µs (-2.60%) Baseline: 2.93 µs	3.31 µs (86.01%)
runtime value to json serde_json/test2.json	📈 view plot 🚷 view threshold	916.18 µs (-6.46%) Baseline: 979.43 µs	1,163.54 µs (78.74%)
runtime value to json serde_json/test3.json	📈 view plot 🚷 view threshold	9,514.10 µs (-4.79%) Baseline: 9,992.43 µs	12,176.41 µs (78.14%)

🐰 View full continuous benchmarking report in Bencher

jonasstrehle · 2025-11-06T13:06:34Z

rebased to release/0.0.7, first merge #497

… annotations

…ed implementation

…and refactoring expression inference

…h type annotations

…g types in statements

… inference functions

…or handling

… VisitAction enum

… responses

jonasstrehle self-assigned this Nov 1, 2025

Copilot AI review requested due to automatic review settings November 1, 2025 09:55

jonasstrehle added non-blocking scope:type-system scope:visitor scope:ast labels Nov 1, 2025

jonasstrehle changed the base branch from main to release/0.0.7 November 1, 2025 09:55

jonasstrehle added this to the Release 0.0.7 milestone Nov 1, 2025

jonasstrehle marked this pull request as draft November 1, 2025 09:56

Copilot AI reviewed Nov 1, 2025

View reviewed changes

src/runtime/mod.rs Outdated Show resolved Hide resolved

src/runtime/mod.rs Outdated Show resolved Hide resolved

jonasstrehle force-pushed the feat/type-inference branch from e4a1f5b to a517a8c Compare November 6, 2025 13:05

jonasstrehle force-pushed the feat/type-inference branch from eae6b4a to fd418c0 Compare November 9, 2025 12:11

jonasstrehle added 15 commits November 9, 2025 21:48

add type inferer

6705b6c

🎨 enhance type inference and expression handling with structural type…

3153820

… annotations

remove option from rich ast

49b4274

refactor: type inference functions to use RichAst directly

7ca60bb

test: add structural type inference for integer literals

01a4ee5

feat: add type annotation handling to TypeExpression and update Spann…

7e1f1da

…ed implementation

feat: enhance type inference by adding variable declaration handling …

65e640e

…and refactoring expression inference

feat: add support for binary operations and variable declarations wit…

b27284a

…h type annotations

feat: enhance variable handling by adding variable access and updatin…

07b1c0b

…g types in statements

docs: enhance type inference

1b81456

refactor: rename type inferer to type inference

d6868a4

refactor: rename type_inferer module to type_inference

bf48a38

refactor: replace direct type annotation setting with mark_type function

7d30642

fmt

cd18b08

feat: add visit_type_declaration method for handling type declarations

52a389c

jonasstrehle added 17 commits November 9, 2025 21:48

feat: enhance type inference with error handling options and refactor…

acbcc69

… inference functions

fmt

86856ae

feat: add detailed error message for InvalidDerefType in TypeError enum

25cb4a0

feat: enhance type inference with additional expression types and err…

c54674f

…or handling

feat: add SetTypeRecurseChildNodes and SetTypeSkipChildren actions to…

65cbd93

… VisitAction enum

feat: refine error handling in TypeInference by adjusting VisitAction…

35449e1

… responses

feat: implement function type inference (WIP)

34e13e4

feat: implement function type inference (WIP)

3c43a23

rename structual type to typealias

79c38b4

feat: Fix structual vs nominal type precompilation (WIP)

bf2a7e1

feat: Fix structual vs nominal type precompilation and type inference

403f31b

test cleanup

7a2ae85

fmt

2f84561

fix: test for type inference

487d3b0

remove println

a931148

feat: Add support for incoming and outgoing block interceptors in ComHub

fbc8cd5

feat: Add support for incoming and outgoing block interceptors in ComHub

4588006

jonasstrehle force-pushed the feat/type-inference branch from 103f67a to 4588006 Compare November 9, 2025 20:49

jonasstrehle requested a review from benStre November 9, 2025 20:49

add box import

12ca689

benStre changed the base branch from release/0.0.7 to main November 9, 2025 20:54

benStre changed the base branch from main to release/0.0.7 November 9, 2025 20:55

benStre added 5 commits November 9, 2025 22:03

rename r#type

085328d

🎨 fmt

8ac80d2

🎨 fmt

9c2509a

🎨 switch kind and name

1597784

add todo

bebe88b

benStre approved these changes Nov 9, 2025

View reviewed changes

benStre marked this pull request as ready for review November 9, 2025 22:28

benStre merged commit b894a5e into release/0.0.7 Nov 9, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Type inference #495

Type inference #495

Uh oh!

jonasstrehle commented Nov 1, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 1, 2025 •

edited

Loading

Uh oh!

jonasstrehle commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Type inference #495

Type inference #495

Uh oh!

Conversation

jonasstrehle commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bencher Report

Uh oh!

jonasstrehle commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonasstrehle commented Nov 1, 2025 •

edited

Loading

github-actions bot commented Nov 1, 2025 •

edited

Loading

github-actions bot commented Nov 1, 2025 •

edited

Loading