Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Embedded Support / nostd / Feature separation #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
benStre merged 37 commits into from
Nov 9, 2025
Merged

Embedded Support / nostd / Feature separation #497

benStre merged 37 commits into from
Nov 9, 2025

Conversation

@benStre
Copy link
Member

@benStre benStre commented Nov 1, 2025

No description provided.

Copilot AI review requested due to automatic review settings November 1, 2025 17:28
Copilot AI reviewed Nov 1, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request migrates the codebase from std to core for no-std compatibility by:

  • Replacing std:: imports with core:: or crate::stdlib:: where appropriate
  • Introducing a new stdsync module for sync primitives (separating std::sync vs spin based on feature flags)
  • Adding new visitor pattern infrastructure for AST traversal
  • Removing ReferenceMutability::Final variant and associated code
  • Reorganizing compiler modules with feature gates

Reviewed Changes

Copilot reviewed 163 out of 164 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/lib.rs Adds stdlib/stdsync module abstractions and feature gates for compiler
src/network/com_interfaces/socket_provider.rs Migrates sync primitives to stdsync module
src/values/*.rs Migrates Display/fmt/ops from std to core
src/references/*.rs Removes Final reference mutability variant
src/visitor/*.rs Adds new visitor pattern infrastructure (new files)
tests/network/*.rs Updates imports from std to core
src/runtime/*.rs Updates imports and adds feature gates for native crypto

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Nov 1, 2025 •
edited
Loading

Test Results

566 tests  ±0   566 ✅ ±0   1m 7s ⏱️ -2s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit a9aa62c. ± Comparison against base commit 626486a.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 1, 2025 •
edited
Loading

🐰 Bencher Report

Branchfeat/embedded
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
microseconds (µs)
(Result Δ%)		Upper Boundary
microseconds (µs)
(Limit %)
dxb to json/test1.json📈 view plot
🚷 view threshold		60.86 µs
(-4.35%)Baseline: 63.63 µs
67.92 µs
(89.61%)
dxb to json/test2.json📈 view plot
🚷 view threshold		13,297.00 µs
(+0.00%)Baseline: 13,296.43 µs
13,720.33 µs
(96.91%)
dxb to json/test3.json📈 view plot
🚷 view threshold		141,000.00 µs
(-1.10%)Baseline: 142,568.57 µs
147,932.36 µs
(95.31%)
dxb to runtime value/test1.json📈 view plot
🚷 view threshold		54.52 µs
(+37.42%)Baseline: 39.67 µs
58.90 µs
(92.56%)
dxb to runtime value/test2.json📈 view plot
🚷 view threshold		14,593.00 µs
(+33.57%)Baseline: 10,925.29 µs
15,806.50 µs
(92.32%)
dxb to runtime value/test3.json📈 view plot
🚷 view threshold		163,020.00 µs
(+68.17%)Baseline: 96,939.00 µs
181,881.18 µs
(89.63%)
json to dxb/test1.json📈 view plot
🚷 view threshold		8,053.10 µs
(+373.66%)Baseline: 1,700.18 µs
9,851.10 µs
(81.75%)
json to dxb/test2.json📈 view plot
🚷 view threshold		8,450,200.00 µs
(+517.35%)Baseline: 1,368,794.29 µs
10,454,168.08 µs
(80.83%)
json to dxb/test3.json📈 view plot
🚷 view threshold		48,423,000.00 µs
(+465.77%)Baseline: 8,558,785.71 µs
59,704,154.03 µs
(81.10%)
json to runtime value datex auto static detection/test1.json📈 view plot
🚷 view threshold		8,020.00 µs
(+370.92%)Baseline: 1,703.05 µs
9,807.65 µs
(81.77%)
json to runtime value datex auto static detection/test2.json📈 view plot
🚷 view threshold		8,432,700.00 µs
(+514.91%)Baseline: 1,371,381.43 µs
10,430,985.59 µs
(80.84%)
json to runtime value datex auto static detection/test3.json📈 view plot
🚷 view threshold		48,163,000.00 µs
(+461.08%)Baseline: 8,583,985.71 µs
59,363,471.11 µs
(81.13%)
json to runtime value datex forced static/test1.json📈 view plot
🚷 view threshold		8,223.70 µs
(+376.43%)Baseline: 1,726.11 µs
10,062.46 µs
(81.73%)
json to runtime value datex forced static/test2.json📈 view plot
🚷 view threshold		8,651,400.00 µs
(+518.11%)Baseline: 1,399,647.14 µs
10,703,575.57 µs
(80.83%)
json to runtime value datex forced static/test3.json📈 view plot
🚷 view threshold		49,465,000.00 µs
(+466.79%)Baseline: 8,727,228.57 µs
60,993,368.76 µs
(81.10%)
json to runtime value datex/test1.json📈 view plot
🚷 view threshold		7,940.30 µs
(+368.16%)Baseline: 1,696.08 µs
9,707.36 µs
(81.80%)
json to runtime value datex/test2.json📈 view plot
🚷 view threshold		8,410,400.00 µs
(+513.28%)Baseline: 1,371,370.00 µs
10,402,379.94 µs
(80.85%)
json to runtime value datex/test3.json📈 view plot
🚷 view threshold		48,266,000.00 µs
(+460.05%)Baseline: 8,618,114.29 µs
59,485,945.36 µs
(81.14%)
json to runtime value json_syntax/test1.json📈 view plot
🚷 view threshold		21.69 µs
(+6.67%)Baseline: 20.34 µs
22.30 µs
(97.27%)
json to runtime value json_syntax/test2.json📈 view plot
🚷 view threshold		6,691.30 µs
(+1.74%)Baseline: 6,576.59 µs
7,023.34 µs
(95.27%)
json to runtime value json_syntax/test3.json📈 view plot
🚷 view threshold		70,964.00 µs
(-13.81%)Baseline: 82,333.14 µs
97,093.59 µs
(73.09%)
json to runtime value serde_json/test1.json📈 view plot
🚷 view threshold		6.46 µs
(+2.21%)Baseline: 6.32 µs
6.61 µs
(97.63%)
json to runtime value serde_json/test2.json📈 view plot
🚷 view threshold		2,133.20 µs
(-0.25%)Baseline: 2,138.46 µs
2,178.59 µs
(97.92%)
json to runtime value serde_json/test3.json📈 view plot
🚷 view threshold		15,016.00 µs
(-7.61%)Baseline: 16,252.29 µs
18,480.13 µs
(81.25%)
runtime init📈 view plot
🚷 view threshold		31.20 µs
(-77.45%)Baseline: 138.32 µs
1,198.65 µs
(2.60%)
runtime value to dxb/test1.json📈 view plot
🚷 view threshold		6.02 µs
(+63.24%)Baseline: 3.68 µs
6.68 µs
(90.11%)
runtime value to dxb/test2.json📈 view plot
🚷 view threshold		1,700.80 µs
(+72.84%)Baseline: 984.02 µs
1,903.71 µs
(89.34%)
runtime value to dxb/test3.json📈 view plot
🚷 view threshold		18,567.00 µs
(+83.80%)Baseline: 10,101.79 µs
21,003.56 µs
(88.40%)
runtime value to json datex/test1.json📈 view plot
🚷 view threshold		71.44 µs
(+3.92%)Baseline: 68.75 µs
73.28 µs
(97.50%)
runtime value to json datex/test2.json📈 view plot
🚷 view threshold		15,296.00 µs
(+5.93%)Baseline: 14,440.29 µs
15,644.83 µs
(97.77%)
runtime value to json datex/test3.json📈 view plot
🚷 view threshold		158,730.00 µs
(+2.69%)Baseline: 154,574.29 µs
162,052.42 µs
(97.95%)
runtime value to json json_syntax/test1.json📈 view plot
🚷 view threshold		10.44 µs
(-2.40%)Baseline: 10.70 µs
11.14 µs
(93.75%)
runtime value to json json_syntax/test2.json📈 view plot
🚷 view threshold		4,325.80 µs
(-4.36%)Baseline: 4,523.13 µs
4,816.89 µs
(89.80%)
runtime value to json json_syntax/test3.json📈 view plot
🚷 view threshold		61,112.00 µs
(-3.57%)Baseline: 63,374.29 µs
70,526.98 µs
(86.65%)
runtime value to json serde_json/test1.json📈 view plot
🚷 view threshold		2.72 µs
(-6.57%)Baseline: 2.91 µs
3.36 µs
(80.96%)
runtime value to json serde_json/test2.json📈 view plot
🚷 view threshold		901.91 µs
(-7.72%)Baseline: 977.39 µs
1,168.94 µs
(77.16%)
runtime value to json serde_json/test3.json📈 view plot
🚷 view threshold		9,526.80 µs
(-4.68%)Baseline: 9,994.24 µs
12,174.34 µs
(78.25%)
🐰 View full continuous benchmarking report in Bencher

@benStre benStre changed the base branch from release/0.0.7 to main November 5, 2025 22:25
@benStre benStre changed the base branch from main to release/0.0.7 November 5, 2025 22:25
@jonasstrehle jonasstrehle added this to the Release 0.0.7 milestone Nov 6, 2025
@jonasstrehle jonasstrehle added enhancement New feature or request embedded-support labels Nov 6, 2025
@jonasstrehle jonasstrehle changed the base branch from release/0.0.7 to main November 6, 2025 12:35
@jonasstrehle jonasstrehle changed the base branch from main to release/0.0.7 November 6, 2025 12:35
@jonasstrehle jonasstrehle changed the base branch from release/0.0.7 to release/0.0.6 November 6, 2025 12:43
@jonasstrehle jonasstrehle changed the base branch from release/0.0.6 to release/0.0.7 November 6, 2025 12:43
@jonasstrehle jonasstrehle self-requested a review November 6, 2025 13:06
@jonasstrehle jonasstrehle mentioned this pull request Nov 6, 2025
Merged
7 tasks
@benStre benStre merged commit 2312077 into release/0.0.7 Nov 9, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@jonasstrehle jonasstrehle jonasstrehle approved these changes

Assignees

@jonasstrehle jonasstrehle

@benStre benStre

Labels

embedded-support enhancement New feature or request

Projects

None yet

Milestone

Release 0.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@benStre @jonasstrehle