dojo: setting eny/now/our shouldn't crash dojo #5841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fang-
reviewed
Jun 13, 2022
pkg/arvo/app/dojo.hoon
Outdated
Comment on lines
535
to
536
| ?: ?=($?(%eny %now %our) p.mad) | ||
| (dy-rash %tan [(crip "{(scow %tas p.mad)} is immutable")] ~) |
There was a problem hiding this comment.
fyi, it's perfectly acceptable (and in fact, more common) to use $?'s shorthand, ?(%etc). But $? is also fine!
The [] here (and below) are superfluous though.
Lastly, both the +crip and +scow calls here are a bit off. (scow %tas %something) is equivalent to (trip %something), and the latter is usually preferred. And if you're going to produce a @t tank instead of a [%leaf tape] one, you probably want to directly concatenate the two: (cat 3 p.mad ' is immutable').
(For more complex interpolations, of course, leaf+"some {(com plex)} string" is still more ergonomic and preferred.)
(To be clear, this is not a big deal, I'm just nit-picking style here and trying to convey nuances.)
Suggested change
| ?: ?=($?(%eny %now %our) p.mad) | |
| (dy-rash %tan [(crip "{(scow %tas p.mad)} is immutable")] ~) | |
| ?: ?=(?(%eny %now %our) p.mad) | |
| (dy-rash %tan (cat 3 p.mad ' is immutable') ~) |
3878de3 to
95e6449
Compare
|
That's much cleaner, thanks! |
Changes dojo to emit a usage message and ignore the request. Fixes urbit#1519
95e6449 to
04672fb
Compare
Fang-
approved these changes
Jun 18, 2022
Fang-
added a commit
that referenced
this pull request
Jul 13, 2022
urbit-os-v2.124
- Fixes an issue where behn would fail to report the next timer to vere
correctly, resulting in timers only firing once every ten minutes.
- Updates |rein to be additive instead of fully replacing existing
configuration. Specifying a single agent to start will no longer stop
other explicitly-started agents.
- Various QoL improvements to dojo.
- Updates DNS requests to go to ~deg instead of ~zod. The Foundation
will take over DNS request handling.
Contributions:
David Farrell (5):
dojo: have dojo check =dir exists before switching
dojo: simplify dir not exist error message build
dojo: setting eny/now/our shouldn't crash dojo
dojo: say how to beat the %dy-edit-busy escape room
dojo: remove unnecessary debug output
Joe Bryan (8):
behn: adds (failing) tests
behn: unconditionally clear runtime timer state on %wake
behn: don't compare pending timers to now
behn: refactor to use +abet pattern
behn: emit %doze on any rescheduling of the next timer
behn: cleans up comments
Merge pull request #5858 from urbit/jb/behn-fix2
test: removes debugging comments from %behn unit tests
Sidnym Ladrut (1):
hood: fix issue w/ rein diff application
Yaseen (1):
eyre: Modify landing title from "OS1" to "Urbit"
fang (16):
clay: render syntax errors at end of file
Merge pull request #5811 from ynx0/patch-1
Merge pull request #5812 from urbit/m/eof-syntax-error
Merge pull request #5837 from dnmfarrell/dnmfarrell/arvo-dy-edit-press-bksp-to-abort
Merge pull request #5840 from dnmfarrell/dnmfarrell/arvo-dojo-check-dir-exists-before-switch
Merge branch 'master' into next/arvo
gall: exclude from traces
Merge pull request #5841 from dnmfarrell/dnmfarrell/arvo-dojo-dont-crash-set-beak
Merge pull request #5863 from sidnym-ladrut/sl/fix-rein-toggle-behaviori
Merge pull request #5868 from urbit/pkova/dns
Merge branch 'master' into next/arvo
Merge pull request #5857 from urbit/jb/behn-fix1
Merge pull request #5855 from urbit/m/gall-quieter
hood: re-patch |rein
Revert "clay: render syntax errors at end of file"
Revert "gall: exclude from traces"
pkova (1):
dns: transfer ship.arvo.network domains from ~zod to ~deg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes dojo to emit a usage message and ignore the request.
Fixes #1519