Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dnmfarrell
Copy link
Contributor

It's too easy to get trapped in the Dojo %dy-edit-busy escape room. Just
type something like:

-build-file /=base/gen/ls/hoon

This modifies the dojo output to tell the user how to get out.

Fixes #1462.

@dnmfarrell
Copy link
Contributor Author

dnmfarrell commented Jun 10, 2022

I wonder if this hint should be emitted as an effect, instead of changing the sigpam value? Or perhaps:

[%dy-edit-busy "(press backspace to abort)"]

And then it's still valid hoon.

edit: I ended up emitting an extra effect with the help text instead of mangling the sigpam line. Then it doesn't break the pattern of using sigpam only to emit %tas.

@dnmfarrell dnmfarrell force-pushed the dnmfarrell/arvo-dy-edit-press-bksp-to-abort branch from bc358f7 to 1e159bc Compare June 10, 2022 21:41
@Fang- Fang- self-requested a review June 13, 2022 21:18
@Fang-
Copy link
Collaborator

Fang- commented Jun 13, 2022

I ended up emitting an extra effect with the help text

This is the most real form of output, and as such the best solution. Good call.

the pattern of using sigpam only to emit %tas.

It's only a pattern in that it's the most common way to easily show debug messages to the user. Of course, we should not be showing debug messages to our users in the first place!

I'd suggest removing the ~& %dy-edit-busy entirely, and printing just "dojo: busy (press backspace to abort)" or similar. (As you've done, I just want the "busy" keyword in there also.)

It's too easy to get trapped in the dojo %dy-edit-busy escape room. Just
type something like:

  -build-file /=base/gen/ls/hoon

This modifies the dojo output to tell the user how to get out.

Fixes urbit#1462.
The tip already communicates to the user that dojo is busy, so the
sigpam output isn't needed anymore.
@dnmfarrell dnmfarrell force-pushed the dnmfarrell/arvo-dy-edit-press-bksp-to-abort branch from 1e159bc to d8f34e8 Compare June 14, 2022 01:02
@dnmfarrell dnmfarrell changed the title arvo: say how to beat the %dy-edit-busy escape room dojo: say how to beat the %dy-edit-busy escape room Jun 14, 2022
@dnmfarrell
Copy link
Contributor Author

Ahh that's gtk about the sigpam output. Thanks!

Copy link
Collaborator

@Fang- Fang- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slick, thank you!

@Fang- Fang- merged commit 5c2631d into urbit:next/arvo Jun 14, 2022
Fang- added a commit that referenced this pull request Jul 13, 2022
urbit-os-v2.124

- Fixes an issue where behn would fail to report the next timer to vere
  correctly, resulting in timers only firing once every ten minutes.
- Updates |rein to be additive instead of fully replacing existing
  configuration. Specifying a single agent to start will no longer stop
  other explicitly-started agents.
- Various QoL improvements to dojo.
- Updates DNS requests to go to ~deg instead of ~zod. The Foundation
  will take over DNS request handling.

Contributions:

David Farrell (5):
      dojo: have dojo check =dir exists before switching
      dojo: simplify dir not exist error message build
      dojo: setting eny/now/our shouldn't crash dojo
      dojo: say how to beat the %dy-edit-busy escape room
      dojo: remove unnecessary debug output

Joe Bryan (8):
      behn: adds (failing) tests
      behn: unconditionally clear runtime timer state on %wake
      behn: don't compare pending timers to now
      behn: refactor to use +abet pattern
      behn: emit %doze on any rescheduling of the next timer
      behn: cleans up comments
      Merge pull request #5858 from urbit/jb/behn-fix2
      test: removes debugging comments from %behn unit tests

Sidnym Ladrut (1):
      hood: fix issue w/ rein diff application

Yaseen (1):
      eyre: Modify landing title from "OS1" to "Urbit"

fang (16):
      clay: render syntax errors at end of file
      Merge pull request #5811 from ynx0/patch-1
      Merge pull request #5812 from urbit/m/eof-syntax-error
      Merge pull request #5837 from dnmfarrell/dnmfarrell/arvo-dy-edit-press-bksp-to-abort
      Merge pull request #5840 from dnmfarrell/dnmfarrell/arvo-dojo-check-dir-exists-before-switch
      Merge branch 'master' into next/arvo
      gall: exclude from traces
      Merge pull request #5841 from dnmfarrell/dnmfarrell/arvo-dojo-dont-crash-set-beak
      Merge pull request #5863 from sidnym-ladrut/sl/fix-rein-toggle-behaviori
      Merge pull request #5868 from urbit/pkova/dns
      Merge branch 'master' into next/arvo
      Merge pull request #5857 from urbit/jb/behn-fix1
      Merge pull request #5855 from urbit/m/gall-quieter
      hood: re-patch |rein
      Revert "clay: render syntax errors at end of file"
      Revert "gall: exclude from traces"

pkova (1):
      dns: transfer ship.arvo.network domains from ~zod to ~deg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants