test thread: now prints errors/failures in red instead of gray #6896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be2347f to
db3cf2a
Compare
Collaborator
|
Let's rip the clay changes out of this one. We probably want highlighted errors for clay too in the future but it's going to be strange if this is the only error case that clay prints out with red text. |
Contributor
Author
|
I considered that; what I'm wondering is how to find all error cases. I only did this one because I ran into it a lot. Is there an easier way to find all the places where errors are printed besides running into them one by one, saying "Hey, that's an error, it should be in red", and fixing it? |
Collaborator
|
There isn't. We can worry about that later, since even without the clay change this PR is a straight improvement. Rip that change out and I'll merge this. |
pkova
approved these changes
Jan 31, 2024
Fang-
added a commit
that referenced
this pull request
Feb 19, 2024
It appears that bb8ba24 merged changes to /ted/test from #6790 and #6896 incorrectly, as the thread no longer compiled. Because the former PR included the change made to the latter (printing with slog priority 3 in case of failure), the minimum viable fix is taking the contents of /ted/test from #6790 and using those as-is. However, that had hidden success prints behind a "quiet" flag, and provided no way of configuring that from outside the thread. So additionally, we expand the ""vase parsing"" performed on the thread's argument, such that an optional _first_ parameter of a quiet=? may be passed.
pkova
pushed a commit
that referenced
this pull request
Feb 22, 2024
It appears that bb8ba24 merged changes to /ted/test from #6790 and #6896 incorrectly, as the thread no longer compiled. Because the former PR included the change made to the latter (printing with slog priority 3 in case of failure), the minimum viable fix is taking the contents of /ted/test from #6790 and using those as-is. However, that had hidden success prints behind a "quiet" flag, and provided no way of configuring that from outside the thread. So additionally, we expand the ""vase parsing"" performed on the thread's argument, such that an optional _first_ parameter of a quiet=? may be passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When something goes wrong it should print in red. It looks better and adds visual contrast (drawing your eye to the important bit).
Before vs after (test assertion failed):
Before vs after (build failure):
