tests: make /ted/test compile again #6917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that bb8ba24 merged changes to /ted/test from #6790 and #6896 incorrectly, as the thread no longer compiled. Because the former PR included the change made to the latter (printing with slog priority 3 in case of failure), the minimum viable fix is taking the contents of /ted/test from #6790 and using those as-is. However, that had hidden success prints behind a "quiet" flag, and provided no way of configuring that from outside the thread. So additionally, we expand the ""vase parsing"" performed on the thread's argument, such that an optional _first_ parameter of a quiet=? may be passed.
pkova
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that bb8ba24 merged changes to /ted/test from #6790 and #6896 incorrectly, as the thread no longer compiled.
Because the former PR essentially included the change made to the latter (printing with slog priority 3 in case of failure), the minimum viable fix is taking the contents of /ted/test from #6790 and using those as-is.
However, that had hidden success prints behind a "quiet" flag, and provided no way of configuring that from outside the thread. So additionally, we expand the ""vase parsing"" performed on the thread's argument, such that an optional first parameter of a quiet=? may be passed.
(Should the merge commit have had green CI checkmark in light of this? Presumably not, but I'll consider that out of scope for this PR.)
(I also have opinions about the output style change inherited from #6790 here, but right now I just want to run my tests, man...)