zuse: fix parsing of empty segment in +deft:de-purl:html #7048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The URL parser incorrectly handles the case of a trailing empty segment with extension. Without extension, the parser correctly distinguishes paths like `/a/b/` and `/a/b`. When extension follows the last segment, `/a/b/.ext`, `/a/b.ext`, the former path is incorrectly parsed as `/a/b.ext`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URL parser incorrectly handles the case of a trailing empty segment with extension. Without extension, the parser correctly distinguishes paths like
/a/b/and/a/bby supplying an empty path segment in the former case. When extension follows the last segment,/a/b/.ext,/a/b.ext, the former path is incorrectly parsed in the same way as/a/b.ext.Perhaps there was some rationale to this behavior in connection with Clay: it will not commit files without non-empty name. However, the URL parser should still be fixed as proposed here, since the parsing simply does not conform to the URL spec and makes it impossible to interface with earth, where dot files are not uncommon.
I have tested scrying on a ship with modified parser at paths like
/a/b/.ext, and they fail in the same manner as before, with the benefit that/a/b/.extno longer means/a/b.ext.