fix double expanding arguments on Windows #1938
Conversation
|
If defined FEAT_MBYTE and WIN32 both, common_init(), mb_init() are called. Then fix_arg_enc() call alist_expand(). |
|
I found another issue. This run command |
|
I think this calling of slash_adjust is early doing here. diff --git a/src/ex_docmd.c b/src/ex_docmd.c
index c61cd2e95..3bd02c7e1 100644
--- a/src/ex_docmd.c
+++ b/src/ex_docmd.c
@@ -8165,9 +8165,6 @@ alist_add(
{
if (fname == NULL) /* don't add NULL file names */
return;
-#ifdef BACKSLASH_IN_FILENAME
- slash_adjust(fname);
-#endif
AARGLIST(al)[al->al_ga.ga_len].ae_fname = fname;
if (set_fnum > 0)
AARGLIST(al)[al->al_ga.ga_len].ae_fnum = |
|
If applying both patches: This works fine now. |
|
This patch still have issue. For example, if not set enc=utf-8 or other encoding, arguments are not expanded. |
04e0358 to
4628196
Compare
4628196 to
4bf6e44
Compare
|
I once close this because this is not easy to fix. I'll make PR again. |
Codecov Report
@@ Coverage Diff @@
## master #1938 +/- ##
==========================================
+ Coverage 75.11% 75.11% +<.01%
==========================================
Files 76 76
Lines 125301 125301
==========================================
+ Hits 94114 94116 +2
+ Misses 31187 31185 -2
Continue to review full report at Codecov.
|
If defined FEAT_MBYTE and WIN32 both, command-line arguments are parsed twice.
notepad appear twice. I'm not sure well, but this patch seems working good.