Color Emoji (DirectX support improvements) #2375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep `type:directx` use old renderer. `type:directx2` for new renderer.
with log of bugs ;-)
ignore lib files for debug executables
BindDC is not called when turn on DirectX(3) because of IS_ENABLE_DIRECTX() guard in directx_binddc(). The flag which be checked in the macro is not set at where called it. fix #3
* high speed * without color emoji * with some bugs related #4
* Character on cursor was not shown. * Hollow cursor was not shown. * Flush before using GDI functions.
we don't know enough about taamode:3
* add mattn as contributors * change link to referenced code
No need to use "void" for functions without parameters.
Codecov Report
@@ Coverage Diff @@
## master #2375 +/- ##
==========================================
+ Coverage 74.52% 74.54% +0.01%
==========================================
Files 91 91
Lines 132413 132412 -1
Branches 29082 29083 +1
==========================================
+ Hits 98682 98701 +19
- Misses 33706 33707 +1
+ Partials 25 4 -21
Continue to review full report at Codecov.
|
|
From your example it looks like some emojis are cut-off? Does the change in directx rendering fix #1520 perhaps? |
|
As we wrote in |
Closed
|
Where would I get the current test font (Segoe UI Mono)? |
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
Problem: MS-Windows: does not show colored emojis.
Solution: Implement colored emojis. Improve drawing speed. Make 'taamode'
work. (Taro Muraoka, Yasuhiro Matsumoto, Ken Takata, close vim#2375)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces two big features and one small fix to Vim's
DirectX rendering.
Emoji was started from Japan and now widely used in the World as you
know. It has became very important parts for the communication. Recent
Windows supports colored emoji with DirectX, but Vim couldn't use it.
This patch implements colored emoji for Vim.
Vim's DirectX support was not enough about drawing speed. It was caused
by wrong use of DirectX. Now Vim's DirectX rendering is equal or faster
than GDI.
The 'taamode' option didn't work entirely because of incorrect use of
DirectX. This patch fixes it.
And last, this patch is written by collaborating mattn, k-takata and me.
Please enjoy colored 🍣 emoji with this patch. 😄😄😄