Improve color emoji #2401
Closed
Improve color emoji #2401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not switch between GDI and Direct2D if not really needed. - Implement both GDI and D2D version of FillRect and DrawLine.
Use DrawLine in Direct2D mode instead of SetPixel.
introduce DrawingMode to reduce switching
It seems that redrawing is much faster than scrolling when DirectX is used.
Make it customizable whether ScrollWindowEx or RedrawWindow is used.
Need to recreate the render taget when the error is returned.
Most part is written by koron.
It should be called when the cursor should be updated.
Recreate mRT after EndDraw() returns D2DERR_RECREATE_TARGET.
adizero
pushed a commit
to adizero/vim
that referenced
this pull request
May 19, 2018
…pdated
Problem: MS-Windows: drawing underline, curl and strike-throw is slow,
mFallbackDC not properly updated.
Solution: Several performance improvements. (Ken Takata, Taro Muraoka,
Yasuhiro Matsumoto, closes vim#2401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull-request is a supplemental patch for #2375 (v8.0.1343).
This introduces some performance improvements and fixes a bug:
Improve performance when underlines, strikethroughs or undercurls are used.
v8.0.1343 uses GDI to draw these lines, however, switching between DirectX and GDI causes terrible slowdown.
This PR uses Direct2D APIs to draw the lines.
Improve performance when GDI fallback occurs by using a raster font.
This PR draws texts on top of a Direct2D surface even if a raster font is selected.
Add 'scrlines' suboption to the 'rop' option for performance tuning.
On some environments, redrawing is faster than scrolling. (On my environment, redrawing is about 2x faster.)
Users can optimize scrolling behavior by using this suboption.
Fix a bug that the 'mFallbackDC' variable was not properly updated.
See the following URL for the change: vim-jp@080e932
This PR was written by koron and me, and also reviewed by mattn.