This repository was archived by the owner on Jul 29, 2019. It is now read-only.
Fixed Timeline.setGroups for Array #2529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote from docs: "
groupscan be an Array with Objects, a DataSet (offering 2 way data binding), or a DataView (offering 1 way data binding)".However, in #2315 the array support was broken.
The specific change can be seen by comparing develop to master
The problem is
groups.filter(filter), becausefilteris:groupsshould be anArray, sogroups.filteris expecting a function, but is given an object. This results inUncaught TypeError: #<Object> is not a function(to test for yourself just put[].filter({})in your development console).So I changed
filterto be the function, and pass in{filter: filter}toDataView. I felt this was a cleaner solution than passing infilter.filtertogroups.filterbecause the function is the shared information.