Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 29, 2019. It is now read-only.

Timeline Group Visibility #2315

Merged
merged 1 commit into from
Nov 20, 2016
Merged

Timeline Group Visibility #2315

merged 1 commit into from
Nov 20, 2016

Conversation

@simo9000
Copy link
Contributor

Resubmit of #2303. I chose not to completely remove modifications to the library but instead incorporate the method @yotamberk described in #2303 into Timeline.setGroups. This PR will automatically filter groups where group.visible == false. This is more efficient than what I had proposed in #2303 in that the hidden groups do not get rendered, however it still provides a simple imperative means for the library user to hide groups.

@simo9000
Timeline:
4fc37dd 
* Added group option to change the visibility of a group
* updated the groupsEditable example page to demo the use of this feature
* updated the timeline documentation to describe this option
yotamberk
yotamberk approved these changes Nov 14, 2016
View reviewed changes
Copy link
Member

@yotamberk yotamberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! much cleaner =) Good Work

@mojoaxel mojoaxel added this to the Minor Release v4.18 milestone Nov 15, 2016
@yotamberk
Copy link
Member

@mojoaxel Can you please review this?

@linrongbin
Copy link

I like this feature...

@linrongbin
Copy link

When can I get a new release version?

@yotamberk
Copy link
Member

Hopefully next week

@mojoaxel mojoaxel merged commit e79d709 into visjs:develop Nov 20, 2016
@mojoaxel
Copy link
Member

@simo9000 Thanks!

mojoaxel pushed a commit that referenced this pull request Nov 20, 2016
@yotamberk @mojoaxel
Improvements to support group visibility (see #2315) (#2334)
878f0c5 
* Add hidden groups height calculations
* Fix jittering groups
* Remove non-existant parameter
* Cleanup example
* Remove console.log
This was referenced Nov 21, 2016
Closed
Closed
@yotamberk yotamberk mentioned this pull request Nov 30, 2016
Closed
@Broekhuis
Copy link

I cannot get this to work here.. The "hide" buttons don't seem to trigger anything. I am not good at javascript, so perhaps I misunderstood the instructions. I simply replaced the original files with the ones here: https://github.com/almende/vis/pull/2315/files/4fc37ddb862ee4aa8208957635078fe2f6ef80da

I hope someone can help, thanks!

@yotamberk
Copy link
Member

@Broekhuis Are you using the develop version?

@Broekhuis
Copy link

Eh.., I'm not sure... Today I downloaded the ZIP from here : https://github.com/almende/vis/archive/master.zip and then replaced the files mentioned here: https://github.com/almende/vis/pull/2315/files/4fc37ddb862ee4aa8208957635078fe2f6ef80da

@Broekhuis
Copy link

Broekhuis commented Dec 12, 2016 •
edited
Loading

Ah! I just saw on the 'main page' there's a dropdown with which I can choose from many different versions. So I should use: "Branch: develop", right?

@yotamberk
Copy link
Member

yes =)

@Broekhuis
Copy link

@yotamberk Thank you!

@Broekhuis
Copy link

Hm, I installed the develop version, but it still doesn't work here. The hide-buttons don't trigger anything..

I temporarily uploaded it to here: http://www.caporange.com/vis-develop/examples/timeline/groups/groupsEditable.html

Can you see what's wrong?

@simo9000
Copy link
Contributor Author

@Broekhuis I inspected dist/vis.js you have deployed with the groupsEditable.html and it does not contain the library changes from this PR. It looks like you probably need to build the develop branch and redeploy the library.

@simo9000 simo9000 deleted the hideGroups branch December 13, 2016 14:49
@Broekhuis
Copy link

I see... I thought it was enough to simply copy the files and folders, but this sounds as if I need to do something like compiling the code ... I'm afraid this is far beyond my knowledge, so I'll probably just wait until this feature is implemented in the 'normal' version.

Thanks a lot & regards

@lewisjb lewisjb mentioned this pull request Jan 3, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@yotamberk yotamberk yotamberk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Minor Release v4.18

Development

Successfully merging this pull request may close these issues.

5 participants

@simo9000 @yotamberk @linrongbin @mojoaxel @Broekhuis