form validation #166 #171
Open
form validation #166 #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* integration of prettier tailwindcss plugin * reformat codebase Co-authored-by: Aleksey Razbakov <[email protected]>
Open
razbakov
requested changes
Mar 4, 2022
form validation: show error under input
amanuela97
reviewed
Mar 7, 2022
components/TForm.vue
Outdated
| </div> | ||
| <div v-if="error" class="py-4 text-right text-red-500"> | ||
| {{ error.message }} | ||
| {{ errorMessage }} |
Contributor
There was a problem hiding this comment.
i think this is no longer needed?
razbakov
requested changes
Mar 8, 2022
Contributor
razbakov
left a comment
There was a problem hiding this comment.
Please create a demo page with a custom form. I can't register/login neither with Google (auth domain is not configured) nor with email (it requires city to be filled, but autocomplete service is not configured)
razbakov
requested changes
Mar 8, 2022
| }, | ||
| error: { | ||
| type: String, | ||
| default: null, |
Contributor
There was a problem hiding this comment.
I would rather use empty string here to comply with type. AFAIK null is an object.
Suggested change
| default: null, | |
| default: '', |
b04c682 to
057d70e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed
Added validation to add event form
Display error message
How to test
try to save a new event while omitting the required form fields (event type,name,startDate) this fields has a validation attached to it and requires they are not null
Go To
https://thirsty-lalande-50b52c.netlify.app/
My Profile ---> Add Event ---> click Save without filling all fields
Closes #166