Gdamore/1.24 empty procname #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intel pre-release CPUs crash due to index out of bounds when the name is either all spaces or the empty string.
Author
|
This needs to be done for master/1.30 as well. It would be good to upstream these as well. |
ljmf00-wekaio
approved these changes
Aug 19, 2024
Collaborator
|
sorry , didn't see this Garrett until now. I'm fine with pulling this, and adding it to all weka's druntimes... (1.24, 1.30, and 1.38). + upstreaming. I can't test this. You are certain this is all working well? Thanks |
Author
|
@JohanEngelen Seems to be working, but I don't have access to the "special" CPUs (pre-production units) that triggered this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.