Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Gdamore/1.24 empty procname #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdamore wants to merge 2 commits into
base: weka-1.24
Choose a base branch
from
Open

Gdamore/1.24 empty procname #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5fb5db
stub out cache queries from cpuid - they hang on modern EPYC
gdamore Jun 6, 2024
1445f7e
Add bounds checks on processor name.
gdamore Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/core/cpuid.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,13 +883,20 @@ void cpuidX86()
}
// Intel P4 and PM pad at front with spaces.
// Other CPUs pad at end with nulls.
// However, be aware that some "prerelease" CPUs may have completely
// empty (spaces or nulls) values here.
int start = 0, end = 0;
while (cf.processorNameBuffer[start] == ' ') { ++start; }
while (cf.processorNameBuffer[cf.processorNameBuffer.length-end-1] == 0) { ++end; }
cf.processorName = cast(string)(cf.processorNameBuffer[start..$-end]);
while (cf.processorNameBuffer[start] == ' ' && start < cf.processorName.length) { ++start; }
while (cf.processorNameBuffer[cf.processorNameBuffer.length-end-1] == 0 && end < cf.processorName.length) { ++end; }
if (start < end) {
cf.processorName = cast(string)(cf.processorNameBuffer[start..$-end]);
} else {
cf.processorName = "Unknown CPU";
}
} else {
cf.processorName = "Unknown CPU";
}
/*
// Determine cache sizes

// Intel docs specify that they return 0 for 0x8000_0005.
Expand Down Expand Up @@ -944,6 +951,7 @@ void cpuidX86()
datacache[0].lineSize = 32;
}
}
*/
if (cf.probablyIntel && max_cpuid >= 0x0B) {
// For Intel i7 and later, use function 0x0B to determine
// cores and hyperthreads.
Expand Down