Redesign trainingsite behaviour, make it more predictable #6666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng_failure_count_
cleanup, updates and fixes before rewriting update_soldier_request()
Author
|
Assigned to tothxa |
Author
|
<@>bunnybot logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created on Mon Mar 24 23:37:08 CET 2025 by Tóth András (tothxa)
Type of Change
Refactoring or actually rewrite
Issue(s) Closed
Re: https://codeberg.org/wl/widelands/pulls/4947#issuecomment-3079131
New Behavior
Training sites now select training steps and request soldiers based on the actual availability of required wares instead of second guessing them from past successes and failures. Internal state became much simpler.
They also recognise when the player limits the inputs to limit the training at the site, and drop soldiers immedieately when they can't be trained further because of that.
Soldier preference can be changed by the player.
Possible Regressions
Everything related to training, including its saveloading
Additional context
I'm targeting this after v1.3 because it will need a lot of testing in many situations and with many player styles.
I'd also like to make
post_timerconfigurable, removetraining_state_multiplier_, either check the presence of the mandatory"sleep"program, or just make the sleep length another configurable parameter of trainingsites, then document the effect of these properly. But these will probably be better in a follow-up PR.