Update and refactoring of cmake files #6902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed cmake_policy, it is invoked by cmake_minimum_required. https://cmake.org/cmake/help/v3.15/command/cmake_minimum_required.html#policy-version
…isions. In my case, cpptrace downloaded libdwarf, libdwarf downloaded zstd. Zstd defines uninstall target here: https://github.com/facebook/zstd/blob/6e58e9a2c42ea344708b72a14052b3bd4581e118/build/cmake/lib/CMakeLists.txt#L289-L298 and widelands had submissive condition here https://codeberg.org/wl/widelands/src/commit/3c351001884dd9dc9eeb8989e81cc065334c7db5/CMakeLists.txt#L602 In this case zstd won the collision and "Make install/uninstall" job was failing. See e.g. https://stackoverflow.com/questions/70381809/how-can-i-avoid-target-name-collisions-when-using-cmake-fetchcontent-add-subdire IMO removing condition "if(NOT TARGET ...)" is better, cmake stops immediately when collision is found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created on Wed Oct 22 22:02:32 CEST 2025 by Pavol Gono (palino)
Type of Change
Refactoring + version update
The major motivation is to enable download and compilation of 3rd party libraries (cpptrace), this is precondition for e.g. https://codeberg.org/wl/widelands/pulls/4902 . Reasons for increase of minimum cmake version:
FetchContent_MakeAvailable- is available from 3.14When compiling sources with recent Visual Studio 2022, I get a lot of warnings:
In addition to version increase, I did many small cleanings, which simplify cmake files. Each commit message should be descriptive enough.
New Behavior
Build system is ready for
FetchContentusage.Possible Regressions
Hopefully none, I tested all these changes together with cpptrace-enabled code in forked repo: https://github.com/gpalino/widelands/actions/runs/18717701122
Additional context
Up to discussion are following removals:
/EHsccompiler flag is not needed for Visual Studio 2022, but I am not sure about older versionscmake/IncludeDirectoriesOld.cmakeandcmake/Modules/FindICU_old.cmake