feat: show connections for token references #6602

eladb · 2024-05-30T15:02:31Z

Resolves #6433 by adding a connection edge when resources reference each other through tokens (e.g. a function references api.url). The fact that these are implicit references doesn't mean they are not references...

Console UI Tweaks

Remove the () from the connection operations because oftentimes they do not represent an actual method name. If we want to distinguish between operations and other types of connections, we should add this to the model and then display.
Only show the operation when there's a sourceOp in the connection. Do not default to the connection name.
In the navigation pane, change the label from "Access" to "Connections".
Restore connections for invokeAsync(). Not sure why they were removed (resolves invokeAsync connection is not displayed in Wing Console #6607)
Change the node title of topics created for bucket notifications to OnXxx instead of onxxx (all lowercase).
Change the lift-based connection name to call.
Change the title for the queue consumer function to Consumer instead of SetConsumer(), also Tick (for schedules), Subscriber (for topics).

Misc

Make the source property of nodeof(x).addConnection() optional and default to this.

Checklist

Title matches Winglang's style guide
Description explains motivation and solution
Tests added (always)
Docs updated (only required for features)
Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Add a connection edge when resources reference each other through tokens (e.g. a function references `api.url`). The fact that these are implicit references doesn't mean they are not references... * Remove the `()` from the connection operations because oftentimes they do not represent an actual method name. If we want to distinguish between operations and other types of connections, we should add this to the model and then display. * Only show the operation when there's a `sourceOp` in the connection. Do not default to the connection name. * In the navigation pane, change the label from "Access" to "Connections". * Restore connections for `invokeAsync()`. Not sure why they were removed. * Make the `source` property of `nodeof(x).addConnection` optional and default to `this`. * Change the node title of topics created for bucket notifications to `OnXxx` instead of `onxxx` (all lowercase). * Change the lift-based connection name to `call`. * Change the title for the queue consumer function to `Consumer` instead of `SetConsumer()`, also `Tick` (for schedules), `Subscriber` (for topics).

github-actions · 2024-05-30T15:02:44Z

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic	Owner
Wing SDK and utility APIs	`@chriscbr`
Wing Console	`@ainvoner`, `@skyrpex`, `@polamoros`
JSON, structs, primitives and collections	`@hasanaburayyan`
Platforms and plugins	`@hasanaburayyan`
Frontend resources (website, react, etc)	`@tsuf239`
Language design	`@chriscbr`
VSCode extension and language server	`@markmcculloh`
Compiler architecture, inflights, lifting	`@yoav-steinberg`
Wing Testing Framework	`@tsuf239`
Wing CLI	`@markmcculloh`
Build system, dev environment, releases	`@markmcculloh`
Library Ecosystem	`@chriscbr`
Documentation	`@hasanaburayyan`
SDK test suite	`@tsuf239`
Examples	`@hasanaburayyan`
Wing Playground	`@eladcon`

monadabot · 2024-05-30T15:07:34Z

Console preview environment is available at https://wing-console-pr-6602.fly.dev 🚀

Last Updated (UTC) 2024-06-06 13:01

skyrpex · 2024-05-31T09:27:00Z

These kind of connections are visually awkward and confusing to me (from parent to child). That's why I suggested a few days ago to use pseudo-containers like these:

We keep a hint of the hierarchy but the connections are easier to read.

skyrpex · 2024-05-31T10:41:54Z

But that's subject for a different PR/proposal.

For now, maybe we could make it so the connections from parent to children go from west to east. I'll try amending the PR.

skyrpex · 2024-05-31T11:35:42Z

For now, maybe we could make it so the connections from parent to children go from west to east. I'll try amending the PR.

Nevermind, a proper refactor of the construct map nodes would be needed. It's a bit of a mess right now and can't easily do it.

Chriscbr

Nice 👍 I added an optional suggestion in a comment

libs/wingsdk/src/target-sim/app.ts

## Checklist - [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [ ] Description explains motivation and solution - [ ] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [x] Docs updated (only required for features) - [x] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

Closes #6597.

This change makes `cloud.Api` endpoint functions visible in the Console's map view.

…call (#6599) fixes #4925 Now you can pass inflight closures and also any `new PreflightClass()` as parameters to a `super()` call in a ctor. What I did is detect these cases and made sure the implicit scope passed to the construct ctor is `$scope` and not `this` which isn't available before `super()` is called. ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

## Checklist - [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [ ] Description explains motivation and solution - [ ] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

Fixes #4444 Replaced the native assert module import to an [external npm package](https://www.npmjs.com/package/assert) for the problematic file. ## Checklist - [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [ ] Description explains motivation and solution - [ ] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

Extends the changes made in #6577 for reducing the time it takes for the simulator to update to cloud.Service and sim.Resource. ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

…eir generated schema object (#6617) fixes #5779 We now only output the relevant structs schemas for each file instead of all structs. This way we make sure structs with the same name in different files don't overwrite each other's schema. ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

part of: #6337

Fixes #6228 ## Checklist - [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [ ] Description explains motivation and solution - [ ] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

…hods (#6633) fixes #6559 The fold mechanism re-generated the IDs used to identify argument lists in the AST. This means that even though we currently detected implicitly optional arguments we lost that information after the closure transform forld operation. I fixed the default fold implementation not to regenerated these IDs, similar to how we preserve expresion IDs during folds, for example. ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

Resolves #6624

Fixes #6629 - [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [ ] Description explains motivation and solution - [ ] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.

Signed-off-by: monada-bot[bot] <[email protected]>

mergify · 2024-06-06T13:03:12Z

Thanks for contributing, @eladb! This PR will now be added to the merge queue, or immediately merged if eladb/token-connections is up-to-date with main and the queue is empty.

monadabot · 2024-06-06T13:29:51Z

Congrats! 🚀 This was released in Wing 0.74.39.

Fixes a visual bug introduced by #6602 where strange connections would show floating around the map.

eladb marked this pull request as ready for review May 31, 2024 09:12

eladb requested review from a team, ainvoner, eladcon, polamoros and skyrpex as code owners May 31, 2024 09:12

Chriscbr approved these changes May 31, 2024

View reviewed changes

libs/wingsdk/src/target-sim/app.ts Show resolved Hide resolved

hasanaburayyan and others added 17 commits June 6, 2024 08:08

feat(console): add discord button to the status bar (#6609)

75bc4e4

Closes #6597.

feat(sdk): show cloud.Api endpoint functions (#6595)

34213b5

This change makes `cloud.Api` endpoint functions visible in the Console's map view.

feat(console): add tests for console sign in (#6608)

7bcfad0

part of: #6337

feat(console): allow collapsing and expanding map nodes (#6627)

3788068

Resolves #6624

Merge branch 'main' into eladb/token-connections

1f63f49

wip

8447634

Merge branch 'main' into eladb/token-connections

aedbf91

chore: self mutation (build.diff)

7439d11

Signed-off-by: monada-bot[bot] <[email protected]>

monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jun 6, 2024

fix test

ec18adb

eladb removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jun 6, 2024

skyrpex approved these changes Jun 6, 2024

View reviewed changes

mergify bot merged commit af69dda into main Jun 6, 2024

mergify bot deleted the eladb/token-connections branch June 6, 2024 13:03

skyrpex mentioned this pull request Jun 6, 2024

fix(console): strange map connections #6646

Merged

mergify bot pushed a commit that referenced this pull request Jun 6, 2024

fix(console): strange map connections (#6646)

6031415

Fixes a visual bug introduced by #6602 where strange connections would show floating around the map.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: show connections for token references #6602

feat: show connections for token references #6602

Uh oh!

eladb commented May 30, 2024 •

edited

Loading

Uh oh!

github-actions bot commented May 30, 2024

Uh oh!

monadabot commented May 30, 2024 •

edited

Loading

Uh oh!

skyrpex commented May 31, 2024

Uh oh!

skyrpex commented May 31, 2024 •

edited

Loading

Uh oh!

skyrpex commented May 31, 2024

Uh oh!

Chriscbr left a comment

Uh oh!

Uh oh!

mergify bot commented Jun 6, 2024

Uh oh!

monadabot commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

feat: show connections for token references #6602

feat: show connections for token references #6602

Uh oh!

Conversation

eladb commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Console UI Tweaks

Misc

Checklist

Uh oh!

github-actions bot commented May 30, 2024

Uh oh!

monadabot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Last Updated (UTC) 2024-06-06 13:01

Uh oh!

skyrpex commented May 31, 2024

Uh oh!

skyrpex commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

skyrpex commented May 31, 2024

Uh oh!

Chriscbr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mergify bot commented Jun 6, 2024

Uh oh!

monadabot commented Jun 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

eladb commented May 30, 2024 •

edited

Loading

monadabot commented May 30, 2024 •

edited

Loading

skyrpex commented May 31, 2024 •

edited

Loading