Release/0.2.0 to main #51
Conversation
Fixing rgb to yuv test
Xv 111 test downsampled vs raw
Documentation
Fixing hfilter unit test
…wn-packet-handling-is-missing
…lated Xv 125 solve minor repo issues api related
Updating programming guide
Index rename due to sln vision integration.
fixing readme to be generic
fixing external deps as top level
mbanth
left a comment
There was a problem hiding this comment.
In general, these files look good for this release. I have made a few comments. However, none of them are significant enough to delay this release. Please consider them as possible work items for the release after this one.
There was a problem hiding this comment.
This Jenkinsfile does not include use of the Build Discarder. Future releases should use it.
| for (unsigned i=1; i<H_RAW; i++) { | ||
| row_index = camera_capture_row(&image_buff[i][0]); | ||
| if (row_index != i) { | ||
| return 1; // TODO handle errors better |
There was a problem hiding this comment.
If it hasn't been done already, it will be worthwhile to search the code for ToDo items and list them in a Jira issue.
| /** | ||
| * | ||
| * | ||
| */ |
There was a problem hiding this comment.
Remove the blank Doxygen comments. Some Doxygen comments for this function already appear in the .h file.
| ------------ | ||
|
|
||
| - CMAKE | ||
| - XMOS tools |
There was a problem hiding this comment.
It may be worthwhile to include the minimum version of the tools here (and the same for any other required packages) so that the reader doesn't have to go into the documentation for this information.
No description provided.