3685: Remove zio's Duration and replace it with java.time.Duration #4026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is for #3685 |
jdegoes
reviewed
Jul 30, 2020
| testM("foreachPar fail") { | ||
| val io = for { | ||
| trace <- TestClock.setTime(1.second) *> foreachParFail | ||
| trace <- TestClock.setTime(fromSeconds(1)) *> foreachParFail |
There was a problem hiding this comment.
Let's have extension methods in zio.duration._ so we can still use the same syntax as before. Will help ensure people don't have to change their code.
There was a problem hiding this comment.
Good point, we can still use extension methods.
jdegoes
reviewed
Jul 30, 2020
| } @@ jvmOnly @@ zioTag(interruption), | ||
| testM("timeout in uninterruptible region") { | ||
| val effect = (ZIO.unit.timeout(Duration.Infinity)).uninterruptible | ||
| val effect = (ZIO.unit.timeout(zio.duration.infiniteDuration)).uninterruptible |
There was a problem hiding this comment.
We can still keep Duration.Infinity / etc. There can be a type alias Duration inside zio.duration which delegates to java.time.Duration, then there can be a companion object with vals inside it and helpers. So overall almost no code should change in user-land.
|
Closing this because I opened a new one: #4029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.