3685: Replace Duration with java.time.Duration #4029
Conversation
|
@adrianfilip Looks great! Will review in more detail but can you fix the compilation failures on the documentation? |
|
@adamgfraser Thanks. Yes, I am on that now. |
| import zio.duration.Duration | ||
| val duration = Duration.fromNanos(1) | ||
| import zio.duration._ | ||
| val duration = 1.nanos |
There was a problem hiding this comment.
We should be able to keep Duration.fromNanos just for backward compatibility reasons.
There was a problem hiding this comment.
Plus other ones that existed, like fromMillis.
There was a problem hiding this comment.
It's still there but there are a few places where I used the new .nanos instead. Should I revert it in those places?
There was a problem hiding this comment.
I will revert the change to .nanos to make it easier to track changes.
There was a problem hiding this comment.
Yes, if you can do it without any changes outside zio.duration._, then it's a great sign users won't have any pains, either!
| case Duration.Finite(nanos) => | ||
| case Duration.Infinity => once >>> never.as(1) | ||
| case Duration.Zero => forever | ||
| case duration => |
There was a problem hiding this comment.
Through object Finite apply & unapply, we can preserve backward compatibility here and reduce changes.
There was a problem hiding this comment.
Oh I see. We still want the notion of Finite. I'll make the changes.
There was a problem hiding this comment.
I think if we can make this change backward compatible, it would go a long way to easing migration for 1.0. Thank you!
|
The new PR is: #4034 |
Using the suggestions from #4026