Implement ZIO#cachedInvalidate #4710
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's really great and a much awaited feature! Just a comment though, I'm not sure about the naming, it doesn't tell me if I don't know that this combinator gives me the possibility to invalidate. |
|
@remiguittaut Yes, I wasn't sure about the name. Changed it based on your suggestion. Open to other ideas as well. |
| } yield assert((a, b, c))(equalTo((0, 0, 0))) | ||
| } | ||
| ), | ||
| suite("cachedWith")( |
There was a problem hiding this comment.
Suggested change
| suite("cachedWith")( | |
| suite("cachedInvalidate")( |
jdegoes
approved these changes
Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've gotten several requests recently for a variant of
cachedthat allows the caller to invalidate the cache before thetimeToLivehas expired. This is potentially getting a little specialized but given user demand I think it makes sense to add and we can implement the currentcachedoperator in terms of this one so it is not adding much new code.