Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement ZIO#cachedInvalidate #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2021
Merged

Implement ZIO#cachedInvalidate #4710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5487a8a
implement ZIO#cachedWith
adamgfraser Feb 18, 2021
a666630
rename
adamgfraser Feb 18, 2021
2231a34
format
adamgfraser Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion core-tests/shared/src/test/scala/zio/ZIOSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ object ZIOSpec extends ZIOBaseSpec {
d <- cache
} yield assert(a)(equalTo(b)) && assert(b)(not(equalTo(c))) && assert(c)(equalTo(d))
},
testM("correctly handled an infinite duration time to live") {
testM("correctly handles an infinite duration time to live") {
for {
ref <- Ref.make(0)
getAndIncrement = ref.modify(curr => (curr, curr + 1))
Expand All @@ -159,6 +159,28 @@ object ZIOSpec extends ZIOBaseSpec {
} yield assert((a, b, c))(equalTo((0, 0, 0)))
}
),
suite("cachedWith")(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
suite("cachedWith")(
suite("cachedInvalidate")(

testM("returns new instances after duration") {
def incrementAndGet(ref: Ref[Int]): UIO[Int] = ref.updateAndGet(_ + 1)
for {
ref <- Ref.make(0)
tuple <- incrementAndGet(ref).cachedInvalidate(60.minutes)
(cached, invalidate) = tuple
a <- cached
_ <- TestClock.adjust(59.minutes)
b <- cached
_ <- invalidate
c <- cached
_ <- TestClock.adjust(1.minute)
d <- cached
_ <- TestClock.adjust(59.minutes)
e <- cached
} yield assert(a)(equalTo(b)) &&
assert(b)(not(equalTo(c))) &&
assert(c)(equalTo(d)) &&
assert(d)(not(equalTo(e)))
}
),
suite("catchAllDefect")(
testM("recovers from all defects") {
val s = "division by zero"
Expand Down
16 changes: 14 additions & 2 deletions core/shared/src/main/scala/zio/ZIO.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,16 @@ sealed trait ZIO[-R, +E, +A] extends Serializable with ZIOPlatformSpecific[R, E,
* Returns an effect that, if evaluated, will return the cached result of
* this effect. Cached results will expire after `timeToLive` duration.
*/
final def cached(timeToLive: Duration): ZIO[R with Clock, Nothing, IO[E, A]] = {
final def cached(timeToLive: Duration): ZIO[R with Clock, Nothing, IO[E, A]] =
cachedInvalidate(timeToLive).map(_._1)

/**
* Returns an effect that, if evaluated, will return the cached result of
* this effect. Cached results will expire after `timeToLive` duration. In
* addition, returns an effect that can be used to invalidate the current
* cached value before the `timeToLive` duration expires.
*/
final def cachedInvalidate(timeToLive: Duration): ZIO[R with Clock, Nothing, (IO[E, A], UIO[Unit])] = {

def compute(start: Long): ZIO[R with Clock, Nothing, Option[(Long, Promise[E, A])]] =
for {
Expand All @@ -303,10 +312,13 @@ sealed trait ZIO[-R, +E, +A] extends Serializable with ZIOPlatformSpecific[R, E,
}
}

def invalidate(cache: RefM[Option[(Long, Promise[E, A])]]): UIO[Unit] =
cache.set(None)

for {
r <- ZIO.environment[R with Clock]
cache <- RefM.make[Option[(Long, Promise[E, A])]](None)
} yield get(cache).provide(r)
} yield (get(cache).provide(r), invalidate(cache))
}

/**
Expand Down