Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Optimize provideSome by pruning dependency graph #8124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

Optimize provideSome by pruning dependency graph #8124

merged 1 commit into from
May 19, 2023

Conversation

@Jesse-Bakker
Copy link
Contributor

Compared to the previous solution, this should take less time at compile time, as the pruning is done earlier to prevent building part of the dependency graph.

/claim #7632

@algora-pbc algora-pbc bot mentioned this pull request May 18, 2023
Closed
@CLAassistant
Copy link

CLAassistant commented May 18, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@Jesse-Bakker Jesse-Bakker force-pushed the optimize-provideSome branch from 96e0580 to f66ff53 Compare May 18, 2023 21:42
adamgfraser
adamgfraser approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@adamgfraser adamgfraser merged commit d7ec517 into zio:series/2.x May 19, 2023
@adamgfraser adamgfraser mentioned this pull request Jun 1, 2023
Open
adamgfraser added a commit that referenced this pull request Jun 1, 2023
@adamgfraser
Upgrade Scala 3 Version And Revert ProvideSome Optimizations (#8165)
a6ce732 
* upgrade scala 3 version

* Revert "Optimize provideSome by pruning dependency graph (#8124)"

This reverts commit d7ec517.

* Revert "Enable -Xcheck-macros on test projects (#8090)"

This reverts commit c9ab604.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jesse-Bakker @CLAassistant @adamgfraser