Do Not Fork Dynamically Accessed Scope #8355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why were the tests removed? |
|
Because we can't add child scopes to a scope that we don't know statically exists. |
|
Hi |
|
@myazinn You can see the updates for yourself here. 😃 |
|
Any chance to get this merged? I got hit by the memory leak in production, not using |
jdegoes
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8353.
We should not create a scope child scope of a scope that we do not know statically is contained in the environment because we might add a scope that was added at a much higher level of the application and leak if we repeatedly add children to this scope.