Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do Not Fork Dynamically Accessed Scope #8355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Do Not Fork Dynamically Accessed Scope #8355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 1 addition & 19 deletions core-tests/shared/src/test/scala/zio/ZIOSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,16 +345,7 @@ object ZIOSpec extends ZIOBaseSpec {
right2 = (promise1.succeed(()) *> ZIO.never).ensuring(promise2.interrupt *> ZIO.never.interruptible)
exit <- ZIO.collectAllPar(List(left, ZIO.collectAllPar(List(right1, right2)))).exit
} yield assert(exit)(failsCause(containsCause(Cause.fail("fail"))))
} @@ nonFlaky,
test("runs finalizers in parallel") {
for {
promise1 <- Promise.make[Nothing, Unit]
promise2 <- Promise.make[Nothing, Unit]
left = ZIO.addFinalizer(promise1.succeed(())) *> promise2.succeed(())
right = promise2.await *> ZIO.addFinalizer(promise1.await)
_ <- ZIO.collectAllPar(List(left, right))
} yield assertCompletes
}
} @@ nonFlaky
),
suite("collectAllParN")(
test("returns results in the same order") {
Expand Down Expand Up @@ -4212,15 +4203,6 @@ object ZIOSpec extends ZIOBaseSpec {
_ <- fiber.join
value <- fiberRef.get
} yield assertTrue(value == 10)
},
test("runs finalizers in parallel") {
for {
promise1 <- Promise.make[Nothing, Unit]
promise2 <- Promise.make[Nothing, Unit]
left = ZIO.addFinalizer(promise1.succeed(())) *> promise2.succeed(())
right = promise2.await *> ZIO.addFinalizer(promise1.await)
_ <- left.zipPar(right)
} yield assertCompletes
}
),
suite("toFuture")(
Expand Down
57 changes: 27 additions & 30 deletions core/shared/src/main/scala/zio/ZIO.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2538,21 +2538,20 @@ sealed trait ZIO[-R, +E, +A]
)
.forkDaemon

ZIO.parallelFinalizersMask(restore => fork(restore(self), false).zip(fork(restore(that), true))).flatMap {
case (left, right) =>
restore(promise.await).foldCauseZIO(
cause =>
left.interruptFork *> right.interruptFork *>
left.await.zip(right.await).flatMap { case (left, right) =>
left.zipWith(right)(f, _ && _) match {
case Exit.Failure(causes) => ZIO.refailCause(cause.stripFailures && causes)
case _ => ZIO.refailCause(cause.stripFailures)
}
},
leftWins =>
if (leftWins) left.join.zipWith(right.join)((a, b) => f(a, b))
else right.join.zipWith(left.join)((b, a) => f(a, b))
)
fork(self, false).zip(fork(that, true)).flatMap { case (left, right) =>
restore(promise.await).foldCauseZIO(
cause =>
left.interruptFork *> right.interruptFork *>
left.await.zip(right.await).flatMap { case (left, right) =>
left.zipWith(right)(f, _ && _) match {
case Exit.Failure(causes) => ZIO.refailCause(cause.stripFailures && causes)
case _ => ZIO.refailCause(cause.stripFailures)
}
},
leftWins =>
if (leftWins) left.join.zipWith(right.join)((a, b) => f(a, b))
else right.join.zipWith(left.join)((b, a) => f(a, b))
)
}
}
}
Expand Down Expand Up @@ -6075,21 +6074,19 @@ object ZIO extends ZIOCompanionPlatformSpecific with ZIOCompanionVersionSpecific
val promise = Promise.unsafe.make[Unit, Unit](FiberId.None)(Unsafe.unsafe)
val ref = new java.util.concurrent.atomic.AtomicInteger(0)
ZIO.transplant { graft =>
ZIO.parallelFinalizersMask { restoreFinalizers =>
ZIO.foreach(as) { a =>
graft {
restore(restoreFinalizers(ZIO.suspendSucceed(f(a)))).foldCauseZIO(
cause => promise.fail(()) *> ZIO.refailCause(cause),
_ =>
if (ref.incrementAndGet == size) {
promise.unsafe.done(ZIO.unit)(Unsafe.unsafe)
ZIO.unit
} else {
ZIO.unit
}
)
}.forkDaemon
}
ZIO.foreach(as) { a =>
graft {
restore(ZIO.suspendSucceed(f(a))).foldCauseZIO(
cause => promise.fail(()) *> ZIO.refailCause(cause),
_ =>
if (ref.incrementAndGet == size) {
promise.unsafe.done(ZIO.unit)(Unsafe.unsafe)
ZIO.unit
} else {
ZIO.unit
}
)
}.forkDaemon
}
}.flatMap { fibers =>
restore(promise.await).foldCauseZIO(
Expand Down