Add test for ZStream.fromIterator about exceptional case
#10062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69c9ff5 to
721902a
Compare
Fatal errors should not be caught. |
721902a to
a6b4998
Compare
a6b4998 to
147ec9c
Compare
hearnadam
reviewed
Jul 30, 2025
| } | ||
| }, | ||
| test("handles exceptions from iterator") { | ||
| check(Gen.small(Gen.const(_), min = 1)) { maxChunkSize => |
There was a problem hiding this comment.
Do either of these tests need Gen?
There was a problem hiding this comment.
The logic is different when maxChunkSize == 1 and maxChunkSize > 1 so it needs to test these 2 cases, which justifies the usage of Gen.
It's copied from the initial test testing fromIterator
hearnadam
previously approved these changes
Jul 30, 2025
hearnadam
reviewed
Jul 30, 2025
Comment on lines
5633
to
5637
| def failingIterator = { | ||
| throw exception | ||
|
|
||
| List(1, 2).iterator | ||
| } |
There was a problem hiding this comment.
could simplify this to just throw + type annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't manage to add a case for a fatal error as I didn't manage to cactch the fatal error. No idea why
Needed for: #10060