Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add test for ZStream.fromIterator about exceptional case #10062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2025
Merged

Add test for ZStream.fromIterator about exceptional case #10062

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
147ec9c
Add test for `ZStream.fromIterator` about exceptional casse
guizmaii Jul 30, 2025
5b7e27e
Review: Simplify
guizmaii Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 26 additions & 5 deletions streams-tests/shared/src/test/scala/zio/stream/ZStreamSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ object ZStreamSpec extends ZIOBaseSpec {
def inParallel(action: => Unit)(implicit ec: ExecutionContext): Unit =
ec.execute(() => action)

def spec =
override def spec: Spec[TestEnvironment with Scope, Any] =
suite("ZStreamSpec")(
suite("Combinators")(
suite("absolve")(
Expand Down Expand Up @@ -5621,11 +5621,32 @@ object ZStreamSpec extends ZIOBaseSpec {
_ <- ZStream.fromIterableZIO(ZIO.succeed(1 to 5000000)).runDrain
} yield assertCompletes
},
test("fromIterator") {
check(Gen.small(Gen.chunkOfN(_)(Gen.int)), Gen.small(Gen.const(_), 1)) { (chunk, maxChunkSize) =>
assertZIO(ZStream.fromIterator(chunk.iterator, maxChunkSize).runCollect)(equalTo(chunk))
suite("fromIterator")(
test("with values") {
check(Gen.small(Gen.chunkOfN(_)(Gen.int)), Gen.small(Gen.const(_), min = 1)) { (chunk, maxChunkSize) =>
assertZIO(ZStream.fromIterator(chunk.iterator, maxChunkSize).runCollect)(equalTo(chunk))
}
},
test("handles exceptions from making the iterator") {
check(Gen.small(Gen.const(_), min = 1)) { maxChunkSize =>
val exception = new RuntimeException("Iterator error")
def failingIterator: Iterator[Int] = throw exception

assertZIO(ZStream.fromIterator(failingIterator, maxChunkSize).runCollect.exit)(fails(equalTo(exception)))
}
},
test("handles exceptions from iterator") {
check(Gen.small(Gen.const(_), min = 1)) { maxChunkSize =>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do either of these tests need Gen?

Copy link
Member Author

@guizmaii guizmaii Jul 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is different when maxChunkSize == 1 and maxChunkSize > 1 so it needs to test these 2 cases, which justifies the usage of Gen.

It's copied from the initial test testing fromIterator

val exception = new RuntimeException("Iterator error")
val failingIterator =
new Iterator[Int] {
def hasNext: Boolean = true
def next(): Int = throw exception
}
assertZIO(ZStream.fromIterator(failingIterator, maxChunkSize).runCollect.exit)(fails(equalTo(exception)))
}
}
},
),
test("fromIteratorSucceed") {
check(Gen.small(Gen.chunkOfN(_)(Gen.int)), Gen.small(Gen.const(_), 1)) { (chunk, maxChunkSize) =>
assertZIO(ZStream.fromIteratorSucceed(chunk.iterator, maxChunkSize).runCollect)(equalTo(chunk))
Expand Down
Loading