Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mijicd
Copy link
Member

@mijicd mijicd commented Sep 21, 2019

Follow-up of #1728 .

As verified in interop-monix, the following changes needed to be introduced:

  • sbt-pgp has to be downgraded to 1.1.0 in order to avoid issues with keys.
  • PGP_PASSPHRASE needs to be explicitly loaded.
  • Sonatype credentials has to be set on release.
  • Only one workflow is required.

@mijicd mijicd requested a review from ghostdogpr September 21, 2019 18:31
ghostdogpr
ghostdogpr previously approved these changes Sep 21, 2019
@softinio softinio self-requested a review September 21, 2019 22:51
softinio
softinio previously approved these changes Sep 21, 2019
@mijicd
Copy link
Member Author

mijicd commented Sep 22, 2019

Don't merge yet!

@mijicd mijicd dismissed stale reviews from softinio and ghostdogpr via 4af7092 September 22, 2019 07:18
@mijicd
Copy link
Member Author

mijicd commented Sep 22, 2019

The fixes are verified in interop-monix and interop-guava. @ghostdogpr & co. please re-review!

@mijicd mijicd merged commit 4d21b1f into zio:master Sep 22, 2019
@mijicd mijicd deleted the build-cleanup branch September 22, 2019 08:10
ghostdogpr pushed a commit that referenced this pull request Sep 22, 2019
* Migrate StackBoolSpec to ZIO Tests (#1647)

* Fix build issues introduced by bundling (#1754)

* #1647 - converted SerializableSpec to ZTest (#1769)

* Move PlatformLive.ExecutorUtil to Executor companion object. private zio.internal.Sync (#1770)

* Modified dies signature (#1768)

* Modified dies signature

* Added type parameter

* Removed type parameter

* Restart schedule on end in ZStream#scheduleWith (#1767)

* Restart schedule on end

* Remove unused state, add docs

* Port ZStream.fromInputStream to StreamEffect #1460 (#1772)

* Port ZStream.fromInputStream (the one in platform.scala) to StreamEffect #1460

* Port ZStream.fromInputStream (the one in platform.scala) to StreamEffect #1460

* code review updates

* code review updates

* moved buffer to pull call, to avoid mutation

* catch exception and use StreamEffectChunk

* Specify that this fiber will be "inner interrupted" on joining an interrupted Fiber (#1774)

* #1647: Migrate all tests to ZIO Test: Platform spec (#1775)

* Migrate Fiber tests to ZIO Tests (#1647) (#1777)

* Update zio-interop-java to 1.1.0.0-RC5 (#1781)

* Update fs2-core to 2.0.1 (#1779)

* Update sbt-pgp to 1.1.2 (#1780)

* Update zio-interop-monix to 3.0.0.0-RC6 (#1782)

* updated resources page to add my examples (#1783)

* Migrate ZScheduleSpec to ZIO Tests (#1647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants