Port ZStream.fromInputStream (the one in platform.scala) to StreamEffect #1460 #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iravid
requested changes
Sep 22, 2019
| } else { | ||
| a.toByte | ||
| } | ||
| val buf = Array.ofDim[Byte](chunkSize) |
There was a problem hiding this comment.
The buf has to be re-created every time pull runs, or we'll be mutating chunks that have already been emitted.
| } | ||
| val buf = Array.ofDim[Byte](chunkSize) | ||
| def pull(): Chunk[Byte] = { | ||
| val bytesRead = is.read(buf) |
There was a problem hiding this comment.
this needs to be wrapped in try/catch and should catch IOException and re-throw it using StreamEffect.fail
There was a problem hiding this comment.
updated, thanks for help
|
|
||
| final def fromInputStream(is: InputStream): StreamEffect[Any, Nothing, Byte] = | ||
| StreamEffect[Any, Nothing, Byte] { | ||
| Managed.effectTotal { |
There was a problem hiding this comment.
This is not a total effect, I can see Managed.makeEffect which is probably more appropriate here.
There was a problem hiding this comment.
Well the Managed only returns a thunk that, so in that regard it should be total
There was a problem hiding this comment.
This is how we treated all StreamEffect code so far.
XLPI
pushed a commit
to XLPI/zio
that referenced
this pull request
Sep 22, 2019
* Port ZStream.fromInputStream (the one in platform.scala) to StreamEffect zio#1460 * Port ZStream.fromInputStream (the one in platform.scala) to StreamEffect zio#1460 * code review updates * code review updates * moved buffer to pull call, to avoid mutation * catch exception and use StreamEffectChunk
ghostdogpr
pushed a commit
that referenced
this pull request
Sep 22, 2019
* Migrate StackBoolSpec to ZIO Tests (#1647) * Fix build issues introduced by bundling (#1754) * #1647 - converted SerializableSpec to ZTest (#1769) * Move PlatformLive.ExecutorUtil to Executor companion object. private zio.internal.Sync (#1770) * Modified dies signature (#1768) * Modified dies signature * Added type parameter * Removed type parameter * Restart schedule on end in ZStream#scheduleWith (#1767) * Restart schedule on end * Remove unused state, add docs * Port ZStream.fromInputStream to StreamEffect #1460 (#1772) * Port ZStream.fromInputStream (the one in platform.scala) to StreamEffect #1460 * Port ZStream.fromInputStream (the one in platform.scala) to StreamEffect #1460 * code review updates * code review updates * moved buffer to pull call, to avoid mutation * catch exception and use StreamEffectChunk * Specify that this fiber will be "inner interrupted" on joining an interrupted Fiber (#1774) * #1647: Migrate all tests to ZIO Test: Platform spec (#1775) * Migrate Fiber tests to ZIO Tests (#1647) (#1777) * Update zio-interop-java to 1.1.0.0-RC5 (#1781) * Update fs2-core to 2.0.1 (#1779) * Update sbt-pgp to 1.1.2 (#1780) * Update zio-interop-monix to 3.0.0.0-RC6 (#1782) * updated resources page to add my examples (#1783) * Migrate ZScheduleSpec to ZIO Tests (#1647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for #1460