Thanks to visit codestin.com
Credit goes to github.com

Skip to content

resolve #1847 #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 3, 2019
Merged

resolve #1847 #1879

merged 3 commits into from
Oct 3, 2019

Conversation

@mschuwalow
Copy link
Member

adamgfraser
adamgfraser suggested changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@adamgfraser adamgfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Just one comment on the operation over the FiberRef needing to form a Monoid versus a Semigroup. Excited to get this merged!

@adamgfraser adamgfraser merged commit 764d5fd into zio:master Oct 3, 2019
@adamgfraser adamgfraser mentioned this pull request Oct 3, 2019
Merged
Twizty pushed a commit to Twizty/zio that referenced this pull request Nov 13, 2019
@mschuwalow @Twizty
resolve zio#1847 (zio#1879)
c01e516 
* resolve zio#1847

* update docs

* remove scary words
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdegoes jdegoes jdegoes left review comments

+1 more reviewer

@adamgfraser adamgfraser adamgfraser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mschuwalow @jdegoes @adamgfraser