ZIO Test: Harden MockClock #1885
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
MockClockcould be subject to a race condition in some circumstances. Consider the following snippet:In the current implementation this would be flaky. When we adjust the
MockClockwe wake up both the left and the right effects inzipPar. Although we wake up the right effect first, since the effects are on separate fibers their order of completion is indeterminate. So if the left effect completes first, the right effect will set the fiber time to 1 millisecond, leading to data corruption.With the new functionality for specifying custom logic for inheriting
FiberRefinstances implemented in #1879 we can address this by always using the maximum fiber time when combining data from two fibers.