Migrating part of ZIOSpecJvm to zio-test. #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mijicd
reviewed
Oct 10, 2019
| testM("on Left value") { | ||
| assertM(UIO(Left(42)).leftOrFail(ExampleError), equalTo(42)) | ||
| }, | ||
| testM("on Righ value") { |
| def AsyncUnit[E] = IO.effectAsync[E, Unit](_(IO.unit)) | ||
| } | ||
|
|
||
| object UncurriedBracketCompilesRegardlessOrderOfEAndRTypes { |
There was a problem hiding this comment.
Can this be moved outside of spec file?
There was a problem hiding this comment.
Totally seprate file? BracketTypeInferenceSpec.scala?
There was a problem hiding this comment.
Yeah. Not that it matters much, but it's a bit awkward check to mix with regular specs.
|
Nice! |
Twizty
pushed a commit
to Twizty/zio
that referenced
this pull request
Nov 13, 2019
* Migrating part of ZIOSpecJvm to zio-test. * Moved type inference tests to separate file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated random part of ZIOSpecJvm to ZIOSpec, using zio-test