#1647 - Converted ZIOSpecJvm #2206

dkarlinsky · 2019-11-10T18:45:19Z

adamgfraser

This is fantastic! Way to rip through in a day something that had been hanging out there for months! Couple of comments below but looks great.

test/shared/src/main/scala/zio/test/Gen.scala

adamgfraser · 2019-11-10T23:50:29Z

core-tests/jvm/src/test/scala/zio/ZIOSpecJvm.scala

@@ -1,767 +1,643 @@
 package zio


We should move this to the shared folder so these tests run on both the JVM and ScalaJS. It doesn't look like any of them involve blocking effects that wouldn't be available cross-platform. I think it was just labeled this way for historical reasons because not all of the tests had been migrated previously. Ideally we would make these tests part of the existing ZIOSpec.scala file though we may need to split it if the file length gets too long.

Not sure what's a good way to merge it into ZIOSpec.
Right now, it's just a pile of tests with very little grouping by topic/area.
Just dumping everything at end, doesn't sound like a great idea :)

Perhaps this should be a separate issue

They were originally part of the same file and then got split up in #1947 when some of the tests were migrated, so maybe we can organize it similarly to the original version?

Ok, but can we merge this PR and first?
Because I keep seeing changes to ZIOSpecJvm in master...
BTW, I'm not sure how to do what you did in #2210 in ZTest.
(or do I need to change anything? I'm not getting TestClock warnings)

Sure. Let's get this merged.

Can you resolve the merge conflict? I think you can just use the TestClock in the environment.

core-tests/jvm/src/test/scala/zio/ZIOSpecJvm.scala

adamgfraser · 2019-11-11T00:09:29Z

test/shared/src/main/scala/zio/test/package.scala

    case (((a, b), c), d) => f(a, b, c, d)
  }
+
+  implicit class ZioOfTestResultOps[R, E](val res: ZIO[R, E, TestResult]) {


Can we take this out? We have an open issue for the same problem you're dealing with in #1888 and do want to do something about it, but if we do something want to support all the operators and do so in a way that works for all combinations of assert and assertM. Not sure if implicit syntax is the right way to do this. If we make assertions effectual as I am working on in #2182 this problem will solve itself. In the meantime you can do something like:

for { partial <- assertM(partialParse, succeeds(equalTo(List.empty[Int]))) full <- assertM(fullParse, succeeds(equalTo(List(123, 4)))) } yield partial && full

for { partial <- partialParse full <- fullParse } yield assert(partial, succeeds(equalTo(List.empty[Int]))) && assert(full, succeeds(equalTo(List(123, 4))))

I've used this operator a lot in this test, so I moved it into the helper object for the Spec, for now

dkarlinsky · 2019-11-11T16:50:27Z

Doesn't ZTest have TestClock in the environment by default?

…

On Mon, Nov 11, 2019, 5:58 PM Adam Fraser ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In core-tests/jvm/src/test/scala/zio/ZIOSpecJvm.scala <#2206 (comment)>: > @@ -1,767 +1,643 @@ package zio Can you resolve the merge conflict? I think you can just use the TestClock in the environment. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2206?email_source=notifications&email_token=AAMBETYREV6BL7JBCYNOI5LQTF6IPA5CNFSM4JLNUG7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCLDFZMQ#discussion_r344780274>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMBET32DHKZY3DGHDJ4TBLQTF6IPANCNFSM4JLNUG7A> .

adamgfraser · 2019-11-11T16:59:27Z

Yes, you shouldn't have to create it anymore.

…n the same order

t5: For f: Int => String: `IO.bimap(f, identity)` maps an IO[Int, String] into an IO[String, String]

…priate order

…erly

…String] as `IO.flatten` does

…Either[E, String]] as `IO.absolve` does

… due to referential transparency

…uccessOf` does

Check `zipPar` method does not report failure when interrupting loser after it succeeded;

…t merged to master

* t1: IO.foreach` returns the list of results * t2: IO.foreach` both evaluates effects and returns the list of Ints in the same order * t3: `IO.foreach` fails with a NumberFormatException exception * t4: `IO.foreachPar` returns the list of Ints in the same order t5: For f: Int => String: `IO.bimap(f, identity)` maps an IO[Int, String] into an IO[String, String] * t6: IO.collectAllPar` returns the list in the same order * t7: `IO.forkAll` returns the list of Ints in the same order * t8: `IO.collectAllParN` returns the list of Ints in the same order * t9: `IO.foreachParN` returns the list of created Strings in the appropriate order * t10: `IO.foldLeft` with a successful step function sums the list properly * t11: `IO.foldLeft` with a failing step function returns a failed IO * Check done lifts exit result into IO * Check `catchSomeCause` catches matching cause * Check `catchSomeCause` halts if cause doesn't match * Check `when` executes correct branch only * scalafmt * Check `whenM` executes condition effect and correct branch * Check `whenCase` executes correct branch only * Check `whenCaseM` executes condition effect and correct branch * Check `unsandbox` unwraps exception * Check `supervise` returns same value as IO.supervise * Check `flatten` method on IO[E, IO[E, String] returns the same IO[E, String] as `IO.flatten` does * Check `absolve` method on IO[E, Either[E, A]] returns the same IO[E, Either[E, String]] as `IO.absolve` does * Check non-`memoize`d IO[E, A] returns new instances on repeated calls due to referential transparency * Check `cached` method on IO[E, A] returns new instances after duration * Check `raceAll` method returns the same IO[E, A] as `IO.raceAll` does * Check `firstSuccessOf` method returns the same IO[E, A] as `IO.firstSuccessOf` does * Check `zipPar` method does not swallow exit causes of loser; Check `zipPar` method does not report failure when interrupting loser after it succeeded; * Check `orElse` method does not recover from defects * Check `eventually` method succeeds eventually * implemented a large chunk of tests * converted the rest of the tests * Minor changes requested in PR review * implemented "Check `summarized` returns summary and value", which just merged to master * porting changes to ZIOSpecJvm from zio#2169

adamgfraser suggested changes Nov 11, 2019

View reviewed changes

dkarlinsky force-pushed the 1647-ziospecjvm branch from b478e0c to 4a951f4 Compare November 11, 2019 13:06

dkarlinsky force-pushed the 1647-ziospecjvm branch from 4a951f4 to acce0b6 Compare November 12, 2019 08:38

dkarlinsky added 25 commits November 12, 2019 19:43

t1: IO.foreach` returns the list of results

25ae879

t2: IO.foreach` both evaluates effects and returns the list of Ints i…

60f2d8f

…n the same order

t3: IO.foreach fails with a NumberFormatException exception

7c06825

t4: IO.foreachPar returns the list of Ints in the same order

971f296

t5: For f: Int => String: `IO.bimap(f, identity)` maps an IO[Int, String] into an IO[String, String]

t6: IO.collectAllPar` returns the list in the same order

755e580

t7: IO.forkAll returns the list of Ints in the same order

30d2197

t8: IO.collectAllParN returns the list of Ints in the same order

daa58bc

t9: IO.foreachParN returns the list of created Strings in the appro…

c7b4fda

…priate order

t10: IO.foldLeft with a successful step function sums the list prop…

1ee6785

…erly

t11: IO.foldLeft with a failing step function returns a failed IO

4960e63

Check done lifts exit result into IO

d305f98

Check catchSomeCause catches matching cause

ef812e3

Check catchSomeCause halts if cause doesn't match

821f124

Check when executes correct branch only

9846d06

scalafmt

40674fd

Check whenM executes condition effect and correct branch

abbd106

Check whenCase executes correct branch only

6886d15

Check whenCaseM executes condition effect and correct branch

7bd74c4

Check unsandbox unwraps exception

28866ad

Check supervise returns same value as IO.supervise

0590714

Check flatten method on IO[E, IO[E, String] returns the same IO[E, …

8db09c8

…String] as `IO.flatten` does

Check absolve method on IO[E, Either[E, A]] returns the same IO[E, …

fe91f61

…Either[E, String]] as `IO.absolve` does

Check non-memoized IO[E, A] returns new instances on repeated calls…

799d434

… due to referential transparency

Check cached method on IO[E, A] returns new instances after duration

462a7cf

Check raceAll method returns the same IO[E, A] as IO.raceAll does

46d31d2

dkarlinsky added 9 commits November 12, 2019 19:43

Check firstSuccessOf method returns the same IO[E, A] as `IO.firstS…

ed41fa5

…uccessOf` does

Check zipPar method does not swallow exit causes of loser;

e90be29

Check `zipPar` method does not report failure when interrupting loser after it succeeded;

Check orElse method does not recover from defects

7483fe0

Check eventually method succeeds eventually

d60d8b8

implemented a large chunk of tests

032800c

converted the rest of the tests

ab8f53d

Minor changes requested in PR review

c12b43a

implemented "Check summarized returns summary and value", which jus…

60f20e6

…t merged to master

porting changes to ZIOSpecJvm from zio#2169

f47d19a

dkarlinsky force-pushed the 1647-ziospecjvm branch from acce0b6 to f47d19a Compare November 12, 2019 18:19

adamgfraser approved these changes Nov 12, 2019

View reviewed changes

adamgfraser merged commit e995631 into zio:master Nov 12, 2019

dkarlinsky deleted the 1647-ziospecjvm branch November 12, 2019 18:36

Uh oh!

#1647 - Converted ZIOSpecJvm #2206

#1647 - Converted ZIOSpecJvm #2206

Uh oh!

Conversation

dkarlinsky commented Nov 10, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adamgfraser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkarlinsky Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkarlinsky Nov 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dkarlinsky commented Nov 11, 2019 via email

Uh oh!

adamgfraser commented Nov 11, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dkarlinsky commented Nov 10, 2019 •

edited

Loading

dkarlinsky Nov 11, 2019 •

edited

Loading

dkarlinsky Nov 11, 2019 •

edited

Loading