Multi target analyzers #2866
Multi target analyzers #2866
Conversation
…ntax model for cleaner testing of assignability. Added BDN1503. WIP need to do the same for Params.
| { | ||
| System.Diagnostics.Debugger.Launch(); | ||
| } | ||
| var hasCompilerDiagnostics = HasNoCompilerDiagnostics(string.Format(codeTemplate1, targetType, valueExpression), compilation); |
There was a problem hiding this comment.
Should be hasNoCompilerDiagnostics :)
| var syntaxTreesWithInterceptorsNamespaces = compilation.SyntaxTrees.Where(st => st.Options.Features.ContainsKey(InterceptorsNamespaces)); | ||
| var syntaxTree = CSharpSyntaxTree.ParseText(code); | ||
|
|
||
| var compilerDiagnostics = compilation |
There was a problem hiding this comment.
How do you cirmcumvent InterceptorsNamespaces here?
|
Didn't quite follow on the reasoning behind removing a lot of the logic for checking assignability. I don't really want to trigger a diagnostic if the user supplies an illegal value to the attribute, e.g. multidimensional arrays |
| return; | ||
| } | ||
|
|
||
| #if CODE_ANALYSIS_4_8 |
There was a problem hiding this comment.
Clever! I wasn't aware you could solve it like this by multi-targeting
| if (attributeSyntax.ArgumentList.Arguments.All(aas => aas.NameEquals != null)) | ||
| { | ||
| context.ReportDiagnostic(Diagnostic.Create(MustHaveValuesRule, Location.Create(context.FilterTree, attributeSyntax.ArgumentList.Arguments.Span))); | ||
| context.ReportDiagnostic(Diagnostic.Create(MustHaveValuesRule, Location.Create(context.Node.SyntaxTree, attributeSyntax.ArgumentList.Arguments.Span))); |
There was a problem hiding this comment.
I've always used context.FilterTree here, is there any difference to context.Node.SyntaxTree?
| TypeArgumentClassMustBeNonAbstractRule, | ||
| GenericTypeArgumentClassMustBeAnnotatedWithAGenericTypeArgumentsAttributeRule, | ||
| ]; | ||
| }.ToImmutableArray(); |
There was a problem hiding this comment.
Is there any reason why you can't use collection expressions here?
Fixes #2863