-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Multi target analyzers #2866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Multi target analyzers #2866
Conversation
…ntax model for cleaner testing of assignability. Added BDN1503. WIP need to do the same for Params.
|
Didn't quite follow on the reasoning behind removing a lot of the logic for checking assignability. I don't really want to trigger a diagnostic if the user supplies an illegal value to the attribute, e.g. multidimensional arrays |
src/BenchmarkDotNet.Analyzers/Attributes/ParamsAttributeAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/BenchmarkDotNet.Analyzers/Attributes/ParamsAttributeAnalyzer.cs
Outdated
Show resolved
Hide resolved
Much of the logic became unnecessary under the semantic model. The new implementation doesn't check the type of the array passed to the attribute (other than |
Updated to handle more cases. Reverted unknown types test removal.
Uh oh!
There was an error while loading. Please reload this page.