Mask native elements for MRI backtrace #9155
Draft
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0e4c91 to
8a256b7
Compare
At some point, we started including native .java lines in the MRI- formatted trace. This was probably unintended, since MRI-format traces should always follow CRuby's standard of replacing native call frames with the most recent Ruby frame. See jruby#9154 for some discussion of filtering and omitting internal frames (that PR is about Ruby, but the same filtering already applied to native frames used in `caller`). This patch uses the same backtrace gathering logic for the MRI format as it does for `caller`, since in both cases users expect not to see .java frames for internal methods, and now with Ruby 4.0 they will also expect not to see internal Ruby sources.
9e4987f to
dc7674a
Compare
Member
Author
|
This has been rebased against master to avoid 4.0 failing tests hiding whether it breaks anything. It should NOT be applied to JRuby 10.0.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds off of #9154 by also masking internal frames for MRI-formatted backtrace elements. It appears at some point we started showing Java lines in the MRI-formatted trace:
This differs from user expectations and the contents of
callertraces, which both filter out internal methods (native or Ruby) by replacing them with the most recent external Ruby frame (CRuby also implementsInteger#/in native code):The patch here simply uses the
callerbacktrace-gathering logic for the MRI-mode backtrace data.This is opened as a draft because I'm unsure how long this behavior has been broken, and I'm not sure what impact fixing it will have yet. Being based on #9154, that PR should be merged first, but this one needs more evaluation.