Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@florisvdg
Copy link
Contributor

Overview

Adds a GitHub Actions workflow on PRs to ensure all commits are signed, using the check-signed-commits-action.

Type of change

  • Created a new plugin
  • Improved an existing plugin
  • Fixed a bug in an existing plugin
  • Improved contributor utilities or experience

How To Test

Fork the repo and create a PR with an unsigned commit. The check should fail and you should see a comment on the PR.

Changelog

N/A

Copy link
Contributor

@arunsathiya arunsathiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was testing the same setup last night on a personal repository before I could propose it here on Shell Plugins, but you got to it before I could, @florisvdg. 😄 And it works great! 🎉

@arunsathiya arunsathiya added the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Jun 13, 2023
@arunsathiya arunsathiya requested review from AndyTitu and accraw June 15, 2023 04:43
Copy link
Contributor

@AndyTitu AndyTitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. This PR is a good example where unsigned commits were left unnoticed and now the merging process is blocked because of that. This change will fix this type of issues from happening in the future.

@AndyTitu AndyTitu merged commit 112c982 into main Jun 22, 2023
@AndyTitu AndyTitu deleted the check-signed-commit-action branch June 22, 2023 10:13
@arunsathiya arunsathiya removed the waiting-on-reviewer signals that a certain PR is waiting for a review from a 1Password team member label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants