Allow commit signing PR comment on fork PRs #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcoenen
reviewed
Jun 22, 2023
Contributor
Author
|
For some reason the workflow didn't run on this PR. Will have to do more investigation around the |
jpcoenen
approved these changes
Jun 22, 2023
AndyTitu
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Follow-up to #289
Currently, the commit signing check on PRs doesn't show the PR comment if the PR author is external.
This is because the passed in
GITHUB_TOKENdoes not have write access to the PR.For more info about the problem and the solution, see this write-up on the
actions/labelerrepo which has the same problem.Type of change
How To Test
Changelog
N/A