Add preliminary bvh loader #16540

yuripourre · 2025-04-28T21:37:45Z

Hello Babylon.js devs.

I would like to add a preliminary bvh loader to the project.

I haven't tested it thoroughly yet, but I hope to be able to test easily once the playgrounds are updated.

Please share your thoughts and/or suggestions

bjsplat · 2025-04-28T21:39:10Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

deltakosh · 2025-04-28T21:42:26Z

The temp playground link will be created when the checks are green (you have some linting / format issues)

bjsplat · 2025-04-28T21:57:51Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

yuripourre · 2025-04-28T22:24:59Z

Thank you, @deltakosh. Just submitted a fix (hopefully).

bjsplat · 2025-04-28T22:25:52Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-04-28T23:06:17Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-04-28T23:22:20Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

ryantrem

You'd also want to add this plugin to the dynamic.ts file.

packages/dev/loaders/src/BVH/bvhFileLoader.ts

bjsplat · 2025-04-29T00:06:37Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-04-29T02:47:55Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-04-29T03:29:13Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-04-29T03:53:35Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-04-29T04:55:18Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-04-29T05:00:35Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-04-29T05:08:40Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-04-29T05:18:39Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

packages/dev/loaders/src/BVH/bvhFileLoader.ts

packages/dev/loaders/src/BVH/bvhLoader.ts

packages/dev/loaders/test/integration/babylon.sceneLoader.test.ts

packages/dev/loaders/src/BVH/bvhLoader.ts

bjsplat · 2025-04-30T19:44:29Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16540/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-04-30T19:44:29Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16540/merge/testResults/webgpuplaywright/index.html

yuripourre · 2025-04-30T19:47:10Z

Thank you @ryantrem and @RaananW for the reviews, I think I addressed all the comments.

bjsplat · 2025-04-30T22:34:58Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-05-01T17:55:39Z

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

bjsplat · 2025-05-01T18:07:24Z

Snapshot stored with reference name:
refs/pull/16540/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16540/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16540/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16540/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16540/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16540/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16540/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16540/merge#BCU1XR#0

bjsplat · 2025-05-01T18:18:24Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16540/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-05-01T18:21:48Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16540/merge/testResults/webgl2playwright/index.html

bjsplat · 2025-05-01T18:54:50Z

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16540/merge/testResults/webgpuplaywright/index.html

bjsplat · 2025-05-01T18:57:53Z

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16540/merge/testResults/webgl2playwright/index.html

RaananW

LGTM, waiting for @ryantrem to approve as well.

packages/public/@babylonjs/loaders/bvh/license.md

yuripourre · 2025-05-02T18:42:17Z

Thank you so much @RaananW and @ryantrem this feature is a game changer for me!

ryantrem · 2025-05-02T20:36:43Z

Thank you so much @RaananW and @ryantrem this feature is a game changer for me!

Thank you for the contribution!

from #16540 In the current BVH loader, the skeleton will be added to the scene twice when load with `loadAssetContainerAsync`. To solve this, I applied the same approach as the gltf loader's Skeleton creation method. https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/loaders/src/glTF/2.0/glTFLoader.ts#L1378-L1381 --------- Co-authored-by: Raanan Weber <[email protected]>

Add preliminary bvh loader

7e8e886

yuripourre force-pushed the bvh-loader branch from 1a2f2f0 to e960239 Compare April 28, 2025 22:24

yuripourre force-pushed the bvh-loader branch from e960239 to e148a95 Compare April 28, 2025 23:04

yuripourre force-pushed the bvh-loader branch from e148a95 to e1c6823 Compare April 28, 2025 23:20

Fix lint

42fddc8

ryantrem reviewed Apr 29, 2025

View reviewed changes

packages/dev/loaders/src/BVH/bvhFileLoader.ts Show resolved Hide resolved

packages/dev/loaders/src/BVH/bvhFileLoader.ts Outdated Show resolved Hide resolved

yuripourre force-pushed the bvh-loader branch from e1c6823 to 42fddc8 Compare April 29, 2025 00:01

yuripourre added 2 commits April 28, 2025 19:45

Fix lint

fa7f5e7

Update dynamic.ts

244db45

Fix imports

4765b9a

yuripourre force-pushed the bvh-loader branch from 1f0892a to db3d01d Compare April 29, 2025 04:53

yuripourre force-pushed the bvh-loader branch from db3d01d to 5646973 Compare April 29, 2025 04:59

Fix lint

d22347f

yuripourre force-pushed the bvh-loader branch from 5646973 to d22347f Compare April 29, 2025 05:07

Fix lint

afddddd

RaananW reviewed Apr 30, 2025

View reviewed changes

Yuri Pourre added 3 commits April 30, 2025 12:04

Add license information for bvh loader

6db6a44

Update test

225568e

Update bvh files based on comments

4cb4f10

yuripourre force-pushed the bvh-loader branch from 494edfe to 4cb4f10 Compare April 30, 2025 19:19

Yuri Pourre added 2 commits April 30, 2025 12:28

Remove BVHLoader class

465c603

Reduce number of classes

a1bbf33

yuripourre requested review from RaananW and ryantrem April 30, 2025 19:47

Fix lint

82081ea

Fix bvh file loader

39e21fd

yuripourre force-pushed the bvh-loader branch from 2f11912 to 39e21fd Compare May 1, 2025 18:21

RaananW approved these changes May 2, 2025

View reviewed changes

packages/public/@babylonjs/loaders/bvh/license.md Show resolved Hide resolved

ryantrem approved these changes May 2, 2025

View reviewed changes

RaananW merged commit b97759d into BabylonJS:master May 2, 2025
17 checks passed

yuripourre deleted the bvh-loader branch May 2, 2025 18:41

noname0310 mentioned this pull request May 4, 2025

BVH loader loadAsserContainerAsync support #16565

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add preliminary bvh loader #16540

Add preliminary bvh loader #16540

yuripourre commented Apr 28, 2025

bjsplat commented Apr 28, 2025

deltakosh commented Apr 28, 2025

bjsplat commented Apr 28, 2025

yuripourre commented Apr 28, 2025

bjsplat commented Apr 28, 2025

bjsplat commented Apr 28, 2025

bjsplat commented Apr 28, 2025

ryantrem left a comment

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 30, 2025

bjsplat commented Apr 30, 2025

yuripourre commented Apr 30, 2025

bjsplat commented Apr 30, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

RaananW left a comment

yuripourre commented May 2, 2025

ryantrem commented May 2, 2025

Add preliminary bvh loader #16540

Add preliminary bvh loader #16540

Conversation

yuripourre commented Apr 28, 2025

bjsplat commented Apr 28, 2025

deltakosh commented Apr 28, 2025

bjsplat commented Apr 28, 2025

yuripourre commented Apr 28, 2025

bjsplat commented Apr 28, 2025

bjsplat commented Apr 28, 2025

bjsplat commented Apr 28, 2025

ryantrem left a comment

Choose a reason for hiding this comment

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 29, 2025

bjsplat commented Apr 30, 2025

bjsplat commented Apr 30, 2025

yuripourre commented Apr 30, 2025

bjsplat commented Apr 30, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

bjsplat commented May 1, 2025

RaananW left a comment

Choose a reason for hiding this comment

yuripourre commented May 2, 2025

ryantrem commented May 2, 2025