Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WebGPU: Make sure the depth texture is cleared with the right value at creation time #16572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 6, 2025
Merged

WebGPU: Make sure the depth texture is cleared with the right value at creation time #16572

merged 16 commits into from
May 6, 2025

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented May 6, 2025

Popov72 added 15 commits April 9, 2025 12:31
@Popov72
Add support for .exr files
3da4313
@Popov72
Merge branch 'master' of https://github.com/Popov72/Babylon.js
aff4ef7
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
92107c7
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
d6ba9cd
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
b6c3984
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
9fc6a72
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
a096a47
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
5f3e196
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
9a3e3bf
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
57d3f0d
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
a376ef4
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
2fe3a20
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
e4caf10
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js
a044325
@Popov72
Make sure the depth texture is cleared with the right value at creati…
0e99278 
…on time
@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Snapshot stored with reference name:
refs/pull/16572/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16572/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16572/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16572/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16572/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16572/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16572/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16572/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16572/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16572/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16572/merge/testResults/webgpuplaywright/index.html

@deltakosh deltakosh enabled auto-merge (squash) May 6, 2025 15:24
@RaananW
Copy link
Member

RaananW commented May 6, 2025

Not sure of the reason yet, but all tests fail with either timeout or no-render on WebGPU. this is why it takes 60 minutes to run (till the CI pipeline times out).
There won't be any test report, as it is never done.

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16572/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16572/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented May 6, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16572/merge/testResults/webgpuplaywright/index.html

@deltakosh deltakosh merged commit 472cd97 into BabylonJS:master May 6, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

@RaananW RaananW RaananW approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
bug WebGPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Popov72 @bjsplat @RaananW @deltakosh @sebavan