Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix typo in package name. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2018

Conversation

nuclearsandwich
Copy link

My original PR had a typo in the package name. With ros2/rosdistro#373 this PR should get tested on the ROS 2 buildfarm if hooks are set up (which they might not be).

@nuclearsandwich
Copy link
Author

Still not enough to get builds passing. http://build.ros2.org/view/Cpr/job/Cpr__behaviortree_cpp__ubuntu_bionic_amd64/1/console so I'm still investigating.

This package should only be needed if BUILD_TESTING is on and is
find_package'd below if ament_cmake is found and BUILD_TESTING is on.
@nuclearsandwich
Copy link
Author

@facontidavide in 695ad83 I removed what appears to be a spurious find_package(ament_cmake_gtest) and this allowed the build to pass on the ROS 2 buildfarm http://build.ros2.org/view/Cpr/job/Cpr__behaviortree_cpp__ubuntu_bionic_amd64/2/ (yay!) but it also doesn't look like there was any test output and or that tests ran.

@facontidavide facontidavide merged commit 0219e6c into BehaviorTree:ros2 Dec 6, 2018
@nuclearsandwich nuclearsandwich deleted the patch-1 branch December 6, 2018 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants