Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ADD: Highlight first and last segments of bitcoin address#8362

Merged
marcosrdz merged 1 commit into
masterfrom
enhance-address
Mar 3, 2026
Merged

ADD: Highlight first and last segments of bitcoin address#8362
marcosrdz merged 1 commit into
masterfrom
enhance-address

Conversation

@ojokne

@ojokne ojokne commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #8245

Screenshot_1772473988 Screenshot_1772474063 Screenshot_1772537120

GladosBlueWallet
GladosBlueWallet reviewed Mar 2, 2026
View reviewed changes

@GladosBlueWallet GladosBlueWallet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated test-chamber notes (you volunteered).

Comment thread components/CopyTextToClipboard.tsx Outdated
Comment thread components/CopyTextToClipboard.tsx Outdated
Comment thread components/CopyTextToClipboard.tsx Outdated
Comment thread screen/lnd/lndViewInvoice.tsx Outdated
@ojokne ojokne force-pushed the enhance-address branch from a56e98f to 5aa3c9a Compare March 2, 2026 20:51
@ojokne ojokne added the testflight Upload iOS and macOS builds to Testflight. label Mar 3, 2026
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown

✅ Build 7.2.7 (1772515864) has been uploaded to TestFlight and will be available for testing soon.

@ojokne ojokne marked this pull request as ready for review March 3, 2026 06:41
@ncoelho

ncoelho commented Mar 3, 2026

Copy link
Copy Markdown
Member

It would be nice to make this across both receive and send screens. I believe we already had a layout on one of the send flows, multisig maybe?

@GladosBlueWallet

GladosBlueWallet commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains

@GladosBlueWallet

GladosBlueWallet commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @ncoelho] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/ncoelho

@GladosBlueWallet

GladosBlueWallet commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment

@GladosBlueWallet

GladosBlueWallet commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz

Overtorment
Overtorment requested changes Mar 3, 2026
View reviewed changes

@Overtorment Overtorment left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good

Comment thread components/CopyTextToClipboard.tsx Outdated
@ojokne

ojokne commented Mar 3, 2026

Copy link
Copy Markdown
Member Author

It would be nice to make this across both receive and send screens. I believe we already had a layout on one of the send flows, multisig maybe?

did you mean something like this on send confirm screen?

Screenshot_1772537120

@ojokne ojokne force-pushed the enhance-address branch from 5aa3c9a to e1b8fd9 Compare March 3, 2026 12:02
@github-actions

github-actions Bot commented Mar 3, 2026

Copy link
Copy Markdown

✅ Build 7.2.7 (1772540853) has been uploaded to TestFlight and will be available for testing soon.

@ojokne ojokne requested a review from Overtorment March 3, 2026 14:00
Overtorment
Overtorment approved these changes Mar 3, 2026
View reviewed changes

@Overtorment Overtorment left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marcosrdz marcosrdz merged commit 3e8906e into master Mar 3, 2026
14 checks passed
@marcosrdz marcosrdz deleted the enhance-address branch March 3, 2026 17:31
@ojokne ojokne mentioned this pull request Mar 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GladosBlueWallet GladosBlueWallet GladosBlueWallet left review comments
@limpbrains limpbrains limpbrains approved these changes
@Overtorment Overtorment Overtorment approved these changes
@marcosrdz marcosrdz marcosrdz approved these changes
@ncoelho ncoelho Awaiting requested review from ncoelho

Assignees

No one assigned

Labels

testflight Upload iOS and macOS builds to Testflight.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

X enhancement: highlight start/middle/end segment of BTC address for visual verification

6 participants

@ojokne @ncoelho @GladosBlueWallet @limpbrains @Overtorment @marcosrdz