ADD: Highlight first and last segments of bitcoin address#8372
Merged
Conversation
GladosBlueWallet
left a comment
Collaborator
There was a problem hiding this comment.
Test results: I found edge cases. Try not to trip on them.
| destinationAddressView.push( | ||
| <View style={styles.destinationTextContainer} key={`end-${index}`}> | ||
| <Text numberOfLines={0} style={[styles.textDestinationFirstFour, stylesHook.textFiat]}> | ||
| <Text numberOfLines={0} style={[styles.textDestinationFirstSix, stylesHook.textFiat]}> |
Collaborator
There was a problem hiding this comment.
Minor: numberOfLines={0} is a weird no-op (and platform-dependent). If you want unlimited lines, omit numberOfLines; if you want truncation, set a real limit + ellipsizeMode.
|
✅ Build 7.2.7 (1772618571) has been uploaded to TestFlight and will be available for testing soon. |
|
✅ Build 7.2.7 (1772621917) has been uploaded to TestFlight and will be available for testing soon. |
marcosrdz
approved these changes
Mar 4, 2026
ncoelho
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #8362
alternativeTextColor2to match the color used the bitcoin amount displayed on confirm screen