Add receive addresses labels#8755
Open
GladosBlueWallet wants to merge 6 commits into
Open
Conversation
Groundwork for letting users attach a short label to a receive address so future transactions involving that address can display it. - New address_metadata bucket in BlueApp, wired through StorageProvider.
this adds: - a "More options" button replacing the "Receive with amount" link, opening a sheet with "Receive with amount" and "Label" options, each opening its own form sheet - the label is displayed as a small blue pill below the receive card, tappable to edit, visible only when the value exists - rehydrates on reopening the recieve screen
So users can recognize labeled receive addresses at a glance from the wallet's Addresses screen (and ManageWallets), without opening Receive or a transaction to check.
for addresses with labels view the label on transaction details and tap to edit or clear it; transaction list rows show what a tx is associated with as the right subtitle, prioritizing contact > address label > memo/note > empty (multiple labeled outputs are comma separated)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, BlueWallet supports per-transaction memos and per-counterparty labels, but nothing scoped to an individual receive address. This PR adds that, attach a short label to an address once, and see it everywhere that address shows up.
Related issue: #3313
Glados CI replay of #8595 (original author: @r6mez). Temporary in-repo branch for full CI secrets.
Supersedes incorrect fork PR #8754.
Test plan
npm run unit)Made with Cursor