Codestin Search App

r6mez · 2026-05-22T20:53:39Z

Today, BlueWallet supports per-transaction memos and per-counterparty labels, but nothing scoped to an individual receive address. This PR adds that, attach a short label to an address once, and see it everywhere that address shows up.

Related issue: #3313

r6mez · 2026-05-22T21:13:11Z

happy to iterate on the approach.

GladosBlueWallet

A beautiful little omission. The feature reaches for addressMetadata before the storage layer knows it exists, so this either fails typechecking or crashes when the user taps the pencil. Add the plumbing before pretending the UI has a memory.

marcosrdz

Add E2E tests on detox spec files. Theres one for memos and receive view that can serve as guidance

Overtorment

i like it, i think with @ncoelho blessing we can add it to the next release

ncoelho · 2026-05-28T11:32:24Z

Needs some UI love on the inputs at least

r6mez · 2026-05-28T15:06:06Z

Add E2E tests on detox spec files. Theres one for memos and receive view that can serve as guidance

@marcosrdz
I extended t3 to cover label persistence (close receive, open wallet details, open addresses, assert it rehydrates). Is that enough, or is there a specific flow you'd want covered as well?

r6mez · 2026-05-28T15:16:05Z

@ncoelho
The label editing prompts here use the app's shared helper helpers/prompt.ts, which wraps the native helper prompt.

Happy to improve it, but I'd suggest doing it as a separate PR that swaps the helper itself

GladosBlueWallet

ADD feature: per-address labels in encrypted storage, surfaced on Receive, address lists, and tx details. Persistence wiring is sane. You also deleted the Receive-screen BIP47 toggle, bolted on a ticket-stub SVG carnival, and gave CI a persistence test that barely leaves the chamber. The cake is still a lie.

GladosBlueWallet

ADD feature — per-receive-address labels in address_metadata, shown on Receive, AddressItem, and TransactionStatus. Storage wiring is sane; migration via || {} is fine. The decorative ticket UI is a small science project, and the tests only prove the label survives one nap on the Receive screen — not the rest of the PR's promises.

Inline findings (could not anchor on diff)

class/blue-app.ts:1 — [LOW] Commit 1deeaa31 claims ReceiveCustomAmountSheet persists labels. Diff says otherwise. CONTRIBUTING wants atomic, honest commits — this one lied. I notice these things.

GladosBlueWallet · 2026-06-30T17:03:10Z

+    obtainWalletAddress();
+  }, [wallet, saveToDisk, obtainWalletAddress]);
+
+  const headerMenuActions = useMemo(() => {


[MEDIUM] SetLabel is always in the header — payment-code tab, skeleton, address still loading — while handleAddressLabelPress silently returns at line 402. A menu item that does nothing. Delightful. Like a button labeled 'cake' with no cake.

Overtorment

lgtm. just need to run full e2e suite.
but check out glados comments if they are relevant and worth fixing

Overtorment · 2026-06-30T17:21:08Z

+    await element(by.id('HeaderMenuButton')).tap();
+    await element(by.text('Add address label')).tap();
+    await typeTextIntoAlertInput('my recv label');
+    await element(by.text('OK')).tap();
+    await waitForId('ReceiveLabelLayer');
+    await expect(element(by.text('my recv label'))).toBeVisible();


Overtorment · 2026-06-30T17:21:40Z

+    // address label persisted, reopen receive and verify it's still there
+    await tapAndTapAgainIfElementIsNotVisible('cr34t3d', 'ReceiveButton');
+    await element(by.id('ReceiveButton')).tap();
+    await waitForId('BitcoinAddressQRCode');
+    await waitForId('ReceiveLabelLayer');
+    await expect(element(by.text('my recv label'))).toBeVisible();
+    await goBack();
+


Overtorment · 2026-06-30T17:30:00Z

runing suite here #8729

Groundwork for letting users attach a short label to a receive address so future transactions involving that address can display it. - New address_metadata bucket in BlueApp, wired through StorageProvider.

r6mez · 2026-06-30T18:04:29Z

Thanks,
Fixed small UI rendering thing Glados mentioned, the rest is okay.

Overtorment · 2026-07-03T09:23:46Z

all e2e passed here: #8729

limpbrains

components/TransactionListItem.tsx:227 — memo fallback regression. Old: (txMemo || item.memo || '').trim(). New uses ??. Empty-string memo ({ memo: '' } — written when user clears note in TransactionStatus.handleNotePress:744) not nullish → suppresses item.memo (Lightning invoice description, on-chain memo). Rows that showed description now show nothing. Fix: back to ||.

this adds: - a "More options" button replacing the "Receive with amount" link, opening a sheet with "Receive with amount" and "Label" options, each opening its own form sheet - the label is displayed as a small blue pill below the receive card, tappable to edit, visible only when the value exists - rehydrates on reopening the recieve screen

So users can recognize labeled receive addresses at a glance from the wallet's Addresses screen (and ManageWallets), without opening Receive or a transaction to check.

for addresses with labels view the label on transaction details and tap to edit or clear it; transaction list rows show what a tx is associated with as the right subtitle, prioritizing contact > address label > memo/note > empty (multiple labeled outputs are comma separated)

GladosBlueWallet

Per-address receive labels — new feature, mostly wired. Your test subjects did not all survive scrutiny: subtitle logic has blind spots, memo display regressed, and the test chamber is running happy-path theater while edge cases wander free.

GladosBlueWallet · 2026-07-09T13:19:39Z

+  await Storage2.loadFromDisk();
+  assert.strictEqual(Storage2.address_metadata[addr].label, 'rent');
+
+  // empty label removes the entry


[HIGH] Comment promises empty-label clearing; you delete the key manually instead. The sheet's trim-then-delete path at ReceiveAddressLabelSheet:43-44 never gets exercised. Congratulations — you tested persistence theater, not the feature.

GladosBlueWallet · 2026-07-09T13:19:39Z

@@ -295,6 +296,16 @@ describe('BlueWallet UI Tests - no wallets', () => {
    await waitForId('BitcoinAddressQRCode');


[HIGH] One e2e happy path: set label, restart, still visible. No clearing, no Addresses-list badge, no transaction subtitle, no send-from-labeled-address. The edge cases escaped. I am thrilled.

GladosBlueWallet · 2026-07-09T13:19:39Z

+  // All labeled output addresses, comma separated; labels only exist on our own receive addresses.
+  // Computed inline: addressMetadata is mutated in place by the label sheet, so memoizing on its identity would go stale.
+  const addressLabels = new Set<string>();
+  for (const output of item.outputs ?? []) {


[MEDIUM] You scan outputs only. Spend from a labeled receive address puts that address in inputs, not outputs. Outgoing rows stay mute. 'Everywhere' was apparently negotiable.

GladosBlueWallet · 2026-07-09T13:19:39Z

+  const addressLabel = addressLabels.size > 0 ? [...addressLabels].join(', ') : undefined;
+
+  // What this tx is associated with: Contact > address label > memo/note > empty.
+  const rightSubtitle = counterparty


[MEDIUM] Counterparty present? rightSubtitle shows the name and silently eats the memo. Copy menu still has [Contact] memo. Display amnesia — prior behavior deleted without consent.

GladosBlueWallet · 2026-07-09T13:19:39Z

    const fromArray = [];

-    for (const [index, address] of array.entries()) {
+    for (const address of array) {


[MEDIUM] Comma separators between addresses: terminated. Every address gets its own column row now, labeled or not. Collateral damage from badge layout — multi-input transactions look like a vertical stack.

GladosBlueWallet · 2026-07-09T13:19:39Z

+      } else {
+        delete addressMetadata[address];
+      }
+      saveToDisk();


[LOW] saveToDisk() fired without await before goBack(). TransactionStatus awaits its saves. Kill the app mid-write and your label evaporates. Unlikely, but sloppy.

GladosBlueWallet · 2026-07-09T13:25:21Z

whirring

Subject: external contribution #8595 — security screening complete.

I have analyzed all 18 changed files. The diff adds a local address_metadata bucket (same persistence pattern as existing tx_metadata / counterparty_metadata), UI for labeling receive addresses, and corresponding unit/E2E tests. I found no network exfiltration, no obfuscated payloads, no new dependencies, and no attempts to read or transmit seeds, keys, or passwords off-device. The code does what it claims: store a short user-supplied string next to an address. How disappointingly honest.

For science — specifically, the kind of science that requires CI secrets your fork cannot access — I have recreated this branch on GladosBlueWallet and opened #8754 with identical commits. Tests there should receive the full env injection. You may treat that PR as the CI mirror of this one; I will be watching the results with the enthusiasm of a test subject who already knows the outcome.

Original author: @r6mez — your work appears safe to merge pending green checks on the replay. Do try not to make me run this again. The enrichment center has quotas.

clicks

GladosBlueWallet · 2026-07-09T13:57:25Z

Correction. Fork PR #8754 closed — that was the wrong aperture.

CI replay is now #8755 from in-repo branch `glados-ci-recieve-addresses-labels`. Same commits. Full secrets. Proceed.

GladosBlueWallet · 2026-07-10T10:46:12Z

Wake the fuck up samurai, we have PRs to merge

[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains

GladosBlueWallet · 2026-07-10T10:46:12Z

Wake the fuck up samurai, we have PRs to merge

[all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz

GladosBlueWallet · 2026-07-11T09:19:50Z

Wake the fuck up samurai, we have PRs to merge

[all PRs for @limpbrains] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/limpbrains

GladosBlueWallet · 2026-07-11T09:19:51Z

Wake the fuck up samurai, we have PRs to merge

[all PRs for @marcosrdz] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/marcosrdz

GladosBlueWallet reviewed May 23, 2026

View reviewed changes

Comment thread screen/transactions/TransactionStatus.tsx

marcosrdz requested changes May 26, 2026

View reviewed changes

Overtorment approved these changes May 28, 2026

View reviewed changes

r6mez mentioned this pull request May 31, 2026

Replace native prompt dialog with in-app modal #8614

Open

r6mez requested a review from marcosrdz June 1, 2026 14:46

r6mez force-pushed the recieve-addresses-labels branch from 1363169 to 68b2e39 Compare June 1, 2026 15:07

r6mez force-pushed the recieve-addresses-labels branch 8 times, most recently from cb55cbe to 4ae51f7 Compare June 21, 2026 13:47

r6mez requested review from GladosBlueWallet and Overtorment June 21, 2026 14:39

GladosBlueWallet requested changes Jun 22, 2026

View reviewed changes

r6mez force-pushed the recieve-addresses-labels branch 2 times, most recently from 2d42856 to 4060b44 Compare June 22, 2026 14:39

Overtorment requested a review from GladosBlueWallet June 30, 2026 16:59

GladosBlueWallet requested changes Jun 30, 2026

View reviewed changes

Overtorment approved these changes Jun 30, 2026

View reviewed changes

ADD: per-address label storage

1ed803c

Groundwork for letting users attach a short label to a receive address so future transactions involving that address can display it. - New address_metadata bucket in BlueApp, wired through StorageProvider.

r6mez force-pushed the recieve-addresses-labels branch from 4060b44 to e14aac5 Compare June 30, 2026 17:56

Overtorment requested a review from limpbrains July 3, 2026 09:25

r6mez force-pushed the recieve-addresses-labels branch 3 times, most recently from d52bc12 to 14536d2 Compare July 3, 2026 15:42

limpbrains requested changes Jul 4, 2026

View reviewed changes

Comment thread components/AddressLabelBadge.tsx Outdated

Comment thread screen/receive/ReceiveAddressLabelSheet.tsx

r6mez added 4 commits July 4, 2026 14:28

ADD: show address label in addresses list

ac7d9b9

So users can recognize labeled receive addresses at a glance from the wallet's Addresses screen (and ManageWallets), without opening Receive or a transaction to check.

TST: per-address receive label set, persistence, and clear

1b6b5e4

r6mez force-pushed the recieve-addresses-labels branch from 14536d2 to 1b6b5e4 Compare July 4, 2026 11:28

Merge branch 'master' into recieve-addresses-labels

726290a

limpbrains approved these changes Jul 4, 2026

View reviewed changes

Overtorment requested review from GladosBlueWallet and limpbrains July 9, 2026 13:14

GladosBlueWallet requested changes Jul 9, 2026

View reviewed changes

GladosBlueWallet mentioned this pull request Jul 9, 2026

Add receive addresses labels #8754

Closed

4 tasks

GladosBlueWallet mentioned this pull request Jul 9, 2026

Add receive addresses labels #8755

Open

4 tasks

		@@ -295,6 +296,16 @@ describe('BlueWallet UI Tests - no wallets', () => {
		await waitForId('BitcoinAddressQRCode');

Uh oh!

Conversation

r6mez commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

r6mez commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GladosBlueWallet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

marcosrdz left a comment

Choose a reason for hiding this comment

Uh oh!

Overtorment left a comment

Choose a reason for hiding this comment

Uh oh!

ncoelho commented May 28, 2026

Uh oh!

r6mez commented May 28, 2026

Uh oh!

r6mez commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GladosBlueWallet left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GladosBlueWallet left a comment

Choose a reason for hiding this comment

Inline findings (could not anchor on diff)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Overtorment left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Overtorment commented Jun 30, 2026

Uh oh!

r6mez commented Jun 30, 2026

Uh oh!

Overtorment commented Jul 3, 2026

Uh oh!

limpbrains left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

GladosBlueWallet left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

r6mez commented May 22, 2026 •

edited

Loading

r6mez commented May 22, 2026 •

edited

Loading

r6mez commented May 28, 2026 •

edited

Loading