Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Every version bump in
prettier
has a chance to change the desired output and thus break our linting. This PR changes it back to a specific pinned version instead of letting npm and semver take over.Specifically a recent change in 3.5.0 was a "breaking" change for us and changed the desired format of a css file we haven't touched in a a while. It looks like @jjhembd addressed this in 1c892c8 so merging main will work but branches may be "outdated" and break in CI.
We should keep the prettier version updated so we don't have to do as many big refactors like #12206 but it should be intentional instead of randomly when people run
npm install
or when CI installs a different version than people have locally. I did check and pinning the version still has it show up innpm outdated
so the release process should still catch it.Issue number and link
no issue
Testing plan
rm -rf node_modules
npm install
npm run prettier-check
should passAuthor checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change